More report fixes.
Ylian Saint-Hilaire committed
Sep 9, 2021 at 14:50 UTC
10fe94557b1d55cdd0045619aaab0d61b35109c5
5 files changed
+78
-15
db.js
+3
-3
@@ -1409,7 +1409,7 @@ module.exports.CreateDB = function (parent, func) {
1409
obj.GetEventsWithLimit = function (ids, domain, limit, func) { obj.eventsfile.find({ domain: domain, ids: { $in: ids } }).project({ type: 0, _id: 0, domain: 0, ids: 0, node: 0 }).sort({ time: -1 }).limit(limit).toArray(func); };
1410
obj.GetUserEvents = function (ids, domain, username, func) { obj.eventsfile.find({ domain: domain, $or: [{ ids: { $in: ids } }, { username: username }] }).project({ type: 0, _id: 0, domain: 0, ids: 0, node: 0 }).sort({ time: -1 }).toArray(func); };
1411
obj.GetUserEventsWithLimit = function (ids, domain, username, limit, func) { obj.eventsfile.find({ domain: domain, $or: [{ ids: { $in: ids } }, { username: username }] }).project({ type: 0, _id: 0, domain: 0, ids: 0, node: 0 }).sort({ time: -1 }).limit(limit).toArray(func); };
1412
- obj.GetEventsTimeRange = function (ids, domain, msgids, start, end, func) { obj.eventsfile.find({ domain: domain, $or: [{ ids: { $in: ids } }], msgid: { $in: msgids }, time: { $gte: start, $lte: end } }).project({ type: 0, _id: 0, domain: 0, ids: 0, node: 0 }).sort({ time: 1 }).toArray(func); };
1412
+ obj.GetEventsTimeRange = function (ids, domain, msgids, start, end, func) { obj.eventsfile.find({ domain: domain, $or: [{ ids: { $in: ids } }], msgid: { $in: msgids }, time: { $gte: start, $lte: end } }).project({ type: 0, _id: 0, domain: 0, node: 0 }).sort({ time: 1 }).toArray(func); };
1413
obj.GetUserLoginEvents = function (domain, userid, func) { obj.eventsfile.find({ domain: domain, action: { $in: ['authfail', 'login'] }, userid: userid, msgArgs: { $exists: true } }).project({ action: 1, time: 1, msgid: 1, msgArgs: 1, tokenName: 1 }).sort({ time: -1 }).toArray(func); };
1414
obj.GetNodeEventsWithLimit = function (nodeid, domain, limit, func) { obj.eventsfile.find({ domain: domain, nodeid: nodeid }).project({ type: 0, etype: 0, _id: 0, domain: 0, ids: 0, node: 0, nodeid: 0 }).sort({ time: -1 }).limit(limit).toArray(func); };
1415
obj.GetNodeEventsSelfWithLimit = function (nodeid, domain, userid, limit, func) { obj.eventsfile.find({ domain: domain, nodeid: nodeid, userid: { $in: [userid, null] } }).project({ type: 0, etype: 0, _id: 0, domain: 0, ids: 0, node: 0, nodeid: 0 }).sort({ time: -1 }).limit(limit).toArray(func); };
@@ -1598,9 +1598,9 @@ module.exports.CreateDB = function (parent, func) {
1598
};
1599
obj.GetEventsTimeRange = function (ids, domain, msgids, start, end, func) {
1600
if (obj.databaseType == 1) {
1601
- obj.eventsfile.find({ domain: domain, $or: [{ ids: { $in: ids } }], msgid: { $in: msgids }, time: { $gte: start, $lte: end } }, { type: 0, _id: 0, domain: 0, ids: 0, node: 0 }).sort({ time: 1 }).exec(func);
1601
+ obj.eventsfile.find({ domain: domain, $or: [{ ids: { $in: ids } }], msgid: { $in: msgids }, time: { $gte: start, $lte: end } }, { type: 0, _id: 0, domain: 0, node: 0 }).sort({ time: 1 }).exec(func);
1602
} else {
1603
- obj.eventsfile.find({ domain: domain, $or: [{ ids: { $in: ids } }], msgid: { $in: msgids }, time: { $gte: start, $lte: end } }, { type: 0, _id: 0, domain: 0, ids: 0, node: 0 }).sort({ time: 1 }, func);
1603
+ obj.eventsfile.find({ domain: domain, $or: [{ ids: { $in: ids } }], msgid: { $in: msgids }, time: { $gte: start, $lte: end } }, { type: 0, _id: 0, domain: 0, node: 0 }).sort({ time: 1 }, func);
1604
}
1605
};
1606
obj.GetUserLoginEvents = function (domain, userid, func) {
meshrelay.js
+39
-5
@@ -662,14 +662,19 @@ function CreateMeshRelayEx(parent, ws, req, domain, user, cookie) {
662
else if (obj.req.query.p == 2) { msg = 'Ended desktop session', msgid = 11; }
663
else if (obj.req.query.p == 5) { msg = 'Ended file management session', msgid = 12; }
664
else if (obj.req.query.p == 200) { msg = 'Ended messenger session', msgid = 112; }
665
+
666
+ // Get the nodeid and meshid of this device
667
+ var nodeid = (obj.nodeid == null) ? peer.nodeid : obj.nodeid;
668
+ var meshid = (obj.meshid == null) ? peer.meshid : obj.meshid;
669
+
670
if (user) {
671
var event = { etype: 'relay', action: 'relaylog', domain: domain.id, userid: user._id, username: user.name, msgid: msgid, msgArgs: [obj.id, obj.req.clientIp, obj.peer.req.clientIp, Math.floor((Date.now() - ws.time) / 1000)], msg: msg + ' \"' + obj.id + '\" from ' + obj.req.clientIp + ' to ' + obj.peer.req.clientIp + ', ' + Math.floor((Date.now() - ws.time) / 1000) + ' second(s)', protocol: obj.req.query.p, nodeid: obj.req.query.nodeid };
672
if (obj.guestname) { event.guestname = obj.guestname; } else if (peer.guestname) { event.guestname = peer.guestname; } // If this is a sharing session, set the guest name here.
668
- parent.parent.DispatchEvent(['*', user._id], obj, event);
673
+ parent.parent.DispatchEvent(['*', user._id, nodeid, meshid], obj, event);
674
} else if (peer.user) {
675
var event = { etype: 'relay', action: 'relaylog', domain: domain.id, userid: peer.user._id, username: peer.user.name, msgid: msgid, msgArgs: [obj.id, obj.req.clientIp, obj.peer.req.clientIp, Math.floor((Date.now() - ws.time) / 1000)], msg: msg + ' \"' + obj.id + '\" from ' + obj.req.clientIp + ' to ' + obj.peer.req.clientIp + ', ' + Math.floor((Date.now() - ws.time) / 1000) + ' second(s)', protocol: obj.req.query.p, nodeid: obj.req.query.nodeid };
676
if (obj.guestname) { event.guestname = obj.guestname; } else if (peer.guestname) { event.guestname = peer.guestname; } // If this is a sharing session, set the guest name here.
672
- parent.parent.DispatchEvent(['*', peer.user._id], obj, event);
677
+ parent.parent.DispatchEvent(['*', peer.user._id, nodeid, meshid], obj, event);
678
}
679
}
680
@@ -677,6 +682,8 @@ function CreateMeshRelayEx(parent, ws, req, domain, user, cookie) {
682
delete peer.id;
683
delete peer.ws;
684
delete peer.peer;
685
+ delete peer.nodeid;
686
+ delete peer.meshid;
687
if (peer.pingtimer != null) { clearInterval(peer.pingtimer); delete peer.pingtimer; }
688
if (peer.pongtimer != null) { clearInterval(peer.pongtimer); delete peer.pongtimer; }
689
} else {
@@ -710,7 +717,7 @@ function CreateMeshRelayEx(parent, ws, req, domain, user, cookie) {
717
if (tag.logfile.startTime) { event.startTime = tag.logfile.startTime; event.lengthTime = sessionLength; }
718
if (tag.logfile.name) { event.name = tag.logfile.name; }
719
if (tag.logfile.icon) { event.icon = tag.logfile.icon; }
713
- parent.parent.DispatchEvent(['*', 'recording', obj.nodeid, obj.meshid], obj, event);
720
+ parent.parent.DispatchEvent(['*', 'recording', tag.logfile.nodeid, tag.logfile.meshid], obj, event);
721
722
cleanUpRecordings();
723
}, { ws: ws, pws: peer.ws, logfile: logfile });
@@ -725,6 +732,8 @@ function CreateMeshRelayEx(parent, ws, req, domain, user, cookie) {
732
delete obj.id;
733
delete obj.ws;
734
delete obj.peer;
735
+ delete obj.nodeid;
736
+ delete obj.meshid;
737
if (obj.pingtimer != null) { clearInterval(obj.pingtimer); delete obj.pingtimer; }
738
if (obj.pongtimer != null) { clearInterval(obj.pongtimer); delete obj.pongtimer; }
739
@@ -814,10 +823,14 @@ function CreateMeshRelayEx(parent, ws, req, domain, user, cookie) {
823
parent.db.Get(cookie.nodeid, function (err, docs) {
824
if (docs.length == 0) { console.log('ERR: Node not found'); try { obj.close(); } catch (e) { } return; } // Disconnect websocket
825
const node = docs[0];
817
-
826
+
827
// Check if this user has permission to manage this computer
828
if ((parent.GetNodeRights(user, node.meshid, node._id) & MESHRIGHT_REMOTECONTROL) == 0) { console.log('ERR: Access denied (1)'); try { obj.close(); } catch (e) { } return; }
829
830
+ // Set nodeid and meshid
831
+ obj.nodeid = node._id;
832
+ obj.meshid = node.meshid;
833
+
834
// Send connection request to agent
835
const rcookie = parent.parent.encodeCookie({ ruserid: user._id }, parent.parent.loginCookieEncryptionKey);
836
if (obj.id == null) { obj.id = ('' + Math.random()).substring(2); } // If there is no connection id, generate one.
@@ -844,10 +857,14 @@ function CreateMeshRelayEx(parent, ws, req, domain, user, cookie) {
857
parent.db.Get(obj.req.query.nodeid, function (err, docs) {
858
if (docs.length == 0) { console.log('ERR: Node not found'); try { obj.close(); } catch (e) { } return; } // Disconnect websocket
859
const node = docs[0];
847
-
860
+
861
// Check if this user has permission to manage this computer
862
if ((parent.GetNodeRights(user, node.meshid, node._id) & MESHRIGHT_REMOTECONTROL) == 0) { console.log('ERR: Access denied (2)'); try { obj.close(); } catch (e) { } return; }
863
864
+ // Set nodeid and meshid
865
+ obj.nodeid = node._id;
866
+ obj.meshid = node.meshid;
867
+
868
// Send connection request to agent
869
if (obj.id == null) { obj.id = ('' + Math.random()).substring(2); } // If there is no connection id, generate one.
870
const rcookie = parent.parent.encodeCookie({ ruserid: user._id }, parent.parent.loginCookieEncryptionKey);
@@ -897,6 +914,10 @@ function CreateMeshRelayEx(parent, ws, req, domain, user, cookie) {
914
// Check if this user has permission to manage this computer
915
if ((parent.GetNodeRights(user, node.meshid, node._id) & MESHRIGHT_REMOTECONTROL) == 0) { console.log('ERR: Access denied (2)'); try { obj.close(); } catch (e) { } return; }
916
917
+ // Set nodeid and meshid
918
+ obj.nodeid = node._id;
919
+ obj.meshid = node.meshid;
920
+
921
// Send connection request to agent
922
if (obj.id == null) { obj.id = ('' + Math.random()).substring(2); }
923
const rcookie = parent.parent.encodeCookie({ ruserid: user._id, nodeid: node._id }, parent.parent.loginCookieEncryptionKey);
@@ -930,6 +951,19 @@ function CreateMeshRelayEx(parent, ws, req, domain, user, cookie) {
951
performRelay(0);
952
});
953
return obj;
954
+ } else {
955
+ // No routing needed. Just check permissions and fill in the device nodeid and meshid.
956
+ parent.db.Get(obj.req.query.nodeid, function (err, docs) {
957
+ if (docs.length == 0) { console.log('ERR: Node not found'); try { obj.close(); } catch (e) { } return; } // Disconnect websocket
958
+ const node = docs[0];
959
+
960
+ // Check if this user has permission to manage this computer
961
+ if ((parent.GetNodeRights(user, node.meshid, node._id) & MESHRIGHT_REMOTECONTROL) == 0) { console.log('ERR: Access denied (2)'); try { obj.close(); } catch (e) { } return; }
962
+
963
+ // Set nodeid and meshid
964
+ obj.nodeid = node._id;
965
+ obj.meshid = node.meshid;
966
+ });
967
}
968
}
969
meshuser.js
+11
-2
@@ -5413,11 +5413,18 @@ module.exports.CreateMeshUser = function (parent, db, ws, req, args, domain, use
5413
if (common.validateInt(command.type, 1, 1) == false) break; // Validate type
5414
if (common.validateInt(command.groupBy, 1, 3) == false) break; // Validate groupBy: 1 = User, 2 = Device, 3 = Day
5415
if ((typeof command.start != 'number') || (typeof command.end != 'number') || (command.start >= command.end)) break; // Validate start and end time
5416
+ if ((command.devGroup != null) && ((user.links == null) || (user.links[command.devGroup] == null))) break; // Asking for a device group that is not allowed
5417
5418
if (command.type == 1) { // This is the remote session report. Shows desktop, terminal, files...
5419
// If we are not user administrator on this site, only search for events with our own user id.
5420
var ids = [user._id];
5420
- if ((user.siteadmin & SITERIGHT_MANAGEUSERS) != 0) { ids = ['*']; }
5421
+ if ((user.siteadmin & SITERIGHT_MANAGEUSERS) != 0) {
5422
+ if (command.devGroup != null) {
5423
+ ids = [ user._id, command.devGroup ];
5424
+ } else {
5425
+ if (user.links) { for (var i in user.links) { ids.push(i); } }
5426
+ }
5427
+ }
5428
5429
// Get the events in the time range
5430
// MySQL or MariaDB query will ignore the MsgID filter.
@@ -5438,7 +5445,9 @@ module.exports.CreateMeshUser = function (parent, db, ws, req, args, domain, use
5445
5446
// Rows
5447
for (var i in docs) {
5441
- if ((docs[i].msgid != 5) && (docs[i].msgid != 10) && (docs[i].msgid != 11) && (docs[i].msgid != 12) && (docs[i].msgid != 122)) continue; // If MySQL or MariaDB query, we can't filter on MsgID, so we have to do it here.
5448
+ // If MySQL or MariaDB query, we can't filter on MsgID, so we have to do it here.
5449
+ if ((docs[i].msgid != 5) && (docs[i].msgid != 10) && (docs[i].msgid != 11) && (docs[i].msgid != 12) && (docs[i].msgid != 122)) continue;
5450
+ if ((command.devGroup != null) && (docs[i].ids != null) && (docs[i].ids.indexOf(command.devGroup) == -1)) continue;
5451
5452
var entry = { time: docs[i].time.valueOf() };
5453
package.json
+14
-1
@@ -36,6 +36,8 @@
36
"sample-config-advanced.json"
37
],
38
"dependencies": {
39
+ "archiver": "^4.0.2",
40
+ "archiver-zip-encrypted": "^1.0.10",
41
"body-parser": "^1.19.0",
42
"cbor": "~5.2.0",
43
"compression": "^1.7.4",
@@ -43,13 +45,24 @@
45
"express": "^4.17.0",
46
"express-handlebars": "^3.1.0",
47
"express-ws": "^4.0.0",
48
+ "image-size": "^1.0.0",
49
"ipcheck": "^0.1.0",
50
+ "loadavg-windows": "^1.1.1",
51
"minimist": "^1.2.0",
52
+ "mongodb": "^4.1.0",
53
"multiparty": "^4.2.1",
54
+ "mysql": "^2.18.1",
55
"nedb": "^1.8.0",
56
"node-forge": "^0.10.0",
57
+ "node-rdpjs-2": "^0.3.5",
58
+ "node-windows": "^1.0.0-beta.5",
59
+ "otplib": "^10.2.3",
60
+ "saslprep": "^1.0.3",
61
+ "ssh2": "^1.4.0",
62
+ "web-push": "^3.4.5",
63
"ws": "^5.2.3",
52
- "yauzl": "^2.10.0"
64
+ "yauzl": "^2.10.0",
65
+ "yubikeyotp": "^0.2.0"
66
},
67
"repository": {
68
"type": "git",
views/default.handlebars
+11
-4
@@ -7245,7 +7245,7 @@
7245
x += '<div id=d2modenow>';
7246
x += addHtmlValue("Expire Time", '<select id=d2inviteExpire style=float:right;width:250px>' + y + '</select>');
7247
x += '</div><div id=d2moderange style=display:none>';
7248
- x += addHtmlValue("Time Range", '<input id=d2timeRangeSelector style=float:right;width:250px class=flatpickr type="text" placeholder="Select Date & Time.." data-id="altinput">');
7248
+ x += addHtmlValue("Time Range", '<input id=d2timeRangeSelector style=float:right;width:250px class=flatpickr type="text" placeholder="' + "Select Date & Time..." + '" data-id="altinput">');
7249
x += '</div>';
7250
if (currentNode.agent.caps & 1) { x += addHtmlValue("User Consent", '<select id=d2userConsent style=float:right;width:250px><option value=1>' + "Prompt for consent" + '</option><option value=0>' + "Notify Only" + '</option></select>'); }
7251
setDialogMode(2, "Share Device", 3, showShareDeviceEx, x);
@@ -14927,6 +14927,11 @@
14927
for (var i in options) { y += '<option value=' + i + ((settings.groupBy == i)?' selected':'') + '>' + options[i] + '</option>'; }
14928
x += addHtmlValue("Group by", '<select id=d2groupBy style=float:right;width:250px onchange=generateReportDialogValidate()>' + y + '</select>');
14929
14930
+ y = '<option value=0' + ((settings.devGroup == 0)?' selected':'') + '>' + "All" + '</option>';
14931
+ var omeshs = getOrderedList(meshes, 'name');
14932
+ for (var i in omeshs) { y += '<option value=' + encodeURIComponentEx(omeshs[i]._id) + ((settings.devGroup == omeshs[i]._id)?' selected':'') + '>' + EscapeHtml(omeshs[i].name) + '</option>'; }
14933
+ x += addHtmlValue("Device Group", '<select onchange=generateReportDialogValidate() id=d2groupId style=float:right;width:250px>' + y + '</select>');
14934
+
14935
y = '';
14936
if (settings.timeRange == null) { settings.timeRange = 1; }
14937
var options = { 1 : "Last Day", 7: "Last 7 days", 30: "Last 30 days", 0: "Time range" }
@@ -14934,7 +14939,7 @@
14939
x += addHtmlValue("Time", '<select id=d2timeRange style=float:right;width:250px onchange=generateReportDialogValidate()>' + y + '</select>');
14940
14941
x += '<div id=d2timeRangeDiv style=display:none>';
14937
- x += addHtmlValue("Time Range", '<input id=d2timeRangeSelector style=float:right;width:250px class=flatpickr type="text" placeholder="Select Date & Time.." data-id="altinput">');
14942
+ x += addHtmlValue("Time Range", '<input id=d2timeRangeSelector style=float:right;width:250px class=flatpickr type="text" placeholder="' + "Select Date & Time..." + '" data-id="altinput">');
14943
x += '</div>';
14944
14945
setDialogMode(2, "Generate Report", 3, generateReportDialogEx, x);
@@ -14962,8 +14967,10 @@
14967
}
14968
var tz = null;
14969
try { tz = Intl.DateTimeFormat().resolvedOptions().timeZone; } catch (ex) {}
14965
- putstore('_ReportSettings', JSON.stringify({ type: parseInt(Q('d2reportType').value), groupBy: parseInt(Q('d2groupBy').value), timeRange: parseInt(Q('d2timeRange').value) }));
14966
- meshserver.send({ action: 'report', type: parseInt(Q('d2reportType').value), groupBy: parseInt(Q('d2groupBy').value), start: start, end: end, tz: tz, tf: new Date().getTimezoneOffset(), l: getLang() });
14970
+ var devGroup = decodeURIComponent(Q('d2groupId').value);
14971
+ if (devGroup == 0) { devGroup = null; }
14972
+ putstore('_ReportSettings', JSON.stringify({ type: parseInt(Q('d2reportType').value), groupBy: parseInt(Q('d2groupBy').value), timeRange: parseInt(Q('d2timeRange').value), devGroup: devGroup }));
14973
+ meshserver.send({ action: 'report', type: parseInt(Q('d2reportType').value), groupBy: parseInt(Q('d2groupBy').value), start: start, end: end, tz: tz, tf: new Date().getTimezoneOffset(), l: getLang(), devGroup: devGroup });
14974
}
14975
14976
function renderReport(r) {