@cryptotaxi247 / MeshCentral / commits / 1edff6bb

Fix typo: pass -> password key in bare-metal ACM activation log entry (#7848)

The bare-metal ACM activation path at amtprovisioningserver.js:482 writes its log entry under the key 'pass', while every other credential-bearing logAmtActivation caller uses 'password': amtmanager.js:731 (runtime password change) amtmanager.js:2684 (CCM activation) amtmanager.js:2889 (TLS-ACM activation) certoperations.js:120 (ACM sign request) Because the startup loader (meshcentral.js:3800) and the in-line consumer in this same file (amtprovisioningserver.js:635) both gate on typeof <obj>.password == 'string', bare-metal entries write to disk but never enter the in-memory amtPasswords cache. The multi-password fallback in amtmanager.js:577-579 therefore has no cached candidate to try for these devices. Forward-only: existing 'pass'-keyed entries remain skipped by the loader. Also reformats this call to multi-line — it had grown to 14 properties on a single ~382-column line.

Adam DeWolf committed May 29, 2026 at 12:06 UTC 1edff6bb37bbe4a1825a4d53a458004e922ee0e6

1 file changed +16 -1

amtprovisioningserver.js

+16 -1

@@ -479,7 +479,22 @@ module.exports.CreateAmtProvisioningServer = function (parent, config) {

479

480 // Save activation data to amtactivation.log

481 var domain = parent.config.domains[dev.domainid];

482 - obj.logAmtActivation(domain, { time: new Date(), action: 'acmactivate-bare-metal', domain: dev.domainid, amtUuid: dev.guid, newmebx: config.newmebxpassword, mesh: dev.meshid, amtRealm: dev.aquired.realm, amtver: dev.aquired.version, host: dev.aquired.host, ip: dev.addr, user: dev.aquired.user, pass: dev.aquired.pass, tls: dev.aquired.tls, tlshash: dev.aquired.hash });

482 + obj.logAmtActivation(domain, {

483 + time: new Date(),

484 + action: 'acmactivate-bare-metal',

485 + domain: dev.domainid,

486 + amtUuid: dev.guid,

487 + newmebx: config.newmebxpassword,

488 + mesh: dev.meshid,

489 + amtRealm: dev.aquired.realm,

490 + amtver: dev.aquired.version,

491 + host: dev.aquired.host,

492 + ip: dev.addr,

493 + user: dev.aquired.user,

494 + password: dev.aquired.pass,

495 + tls: dev.aquired.tls,

496 + tlshash: dev.aquired.hash

497 + });

498

499 // Update device in the database

500 if (UpdateDevice(dev) == false) return;