Fixed Intel AMT digest header parsing that can cause a server crash.
Ylian Saint-Hilaire committed
Jul 7, 2022 at 15:39 UTC
32d3d24649ee78abd5496063dd8c800cf060e9a1
1 file changed
+4
-6
amt/amt-wsman-comm.js
+4
-6
@@ -170,13 +170,11 @@ var CreateWsmanComm = function (host, port, user, pass, tls, tlsoptions, mpsConn
170
//console.log('SEND: ' + h); // Display send packet
171
}
172
173
- // NODE.js specific private method
174
- obj.parseDigest = function (header) {
175
- var t = header.substring(7).split(',');
176
- for (var i in t) t[i] = t[i].trim();
177
- return t.reduce(function (obj, s) { var parts = s.split('='); obj[parts[0]] = parts[1].replace(new RegExp('\"', 'g'), ''); return obj; }, {})
178
- }
173
+ // Parse the HTTP digest header and return a list of key & values.
174
+ obj.parseDigest = function (header) { return correctedQuoteSplit(header.substring(7)).reduce(function (obj, s) { var parts = s.trim().split('='); obj[parts[0]] = parts[1].replace(new RegExp('\"', 'g'), ''); return obj; }, {}) }
175
176
+ // Split a string on quotes but do not do it when in quotes
177
+ function correctedQuoteSplit(str) { return str.split(',').reduce(function (a, c) { if (a.ic) { a.st[a.st.length - 1] += ',' + c } else { a.st.push(c) } if (c.split('"').length % 2 == 0) { a.ic = !a.ic } return a; }, { st: [], ic: false }).st }
178
function nonceHex(v) { var s = ('00000000' + v.toString(16)); return s.substring(s.length - 8); }
179
180
// NODE.js specific private method