maybe fix weird undefined user login accepted #5870
Signed-off-by: si458 <simonsmith5521@gmail.com>
si458 committed
Mar 1, 2024 at 15:45 UTC
aa87fd61bb01952c91562e7c8ee130bba7a5700f
1 file changed
+1
-1
webserver.js
+1
-1
@@ -2815,7 +2815,7 @@ module.exports.CreateWebServer = function (parent, db, args, certificates, doneF
2815
obj.authenticate(req.query.user, req.query.pass, domain, function (err, userid, passhint, loginOptions) {
2816
// 2FA is not supported in URL authentication method. If user has 2FA enabled, this login method fails.
2817
var user = obj.users[userid];
2818
- if (checkUserOneTimePasswordRequired(domain, user, req, loginOptions) == true) {
2818
+ if ((err == null) && checkUserOneTimePasswordRequired(domain, user, req, loginOptions) == true) {
2819
handleRootRequestEx(req, res, domain, direct);
2820
} else if ((userid != null) && (err == null)) {
2821
// Login success