Added desktop session length into event log when multiplexor is used.
Ylian Saint-Hilaire committed
Sep 9, 2021 at 10:37 UTC
eb30d40e2599cf80872ac7a9e0a1c7e7d106d013
4 files changed
+16
-11
db.js
-1
@@ -1167,7 +1167,6 @@ module.exports.CreateDB = function (parent, func) {
1167
}
1168
};
1169
obj.GetEventsTimeRange = function (ids, domain, msgids, start, end, func) {
1170
- //obj.eventsfile.find({ domain: domain, $or: [{ ids: { $in: ids } }], msgid: { $in: msgids }, time: { $gte: start, $lte: end } }).project({ type: 0, _id: 0, domain: 0, ids: 0, node: 0 }).sort({ time: 1 }).toArray(func);
1170
if (ids.indexOf('*') >= 0) {
1171
sqlDbQuery('SELECT doc FROM events WHERE ((domain = ?) AND (time BETWEEN ? AND ?)) ORDER BY time', [domain, start, end], func);
1172
} else {
meshdesktopmultiplex.js
+10
-6
@@ -119,6 +119,7 @@ function CreateDesktopMultiplexor(parent, domain, nodeid, func) {
119
peer.overflow = false;
120
peer.sendQueue = [];
121
peer.paused = false;
122
+ peer.startTime = Date.now();
123
124
// Add the user to the userids list if needed
125
if ((peer.user != null) && (obj.userIds.indexOf(peer.user._id) == -1)) { obj.userIds.push(peer.user._id); }
@@ -208,6 +209,14 @@ function CreateDesktopMultiplexor(parent, domain, nodeid, func) {
209
if ((obj.viewersOverflowCount < obj.viewers.length) && (obj.recordingFileWriting == false) && obj.agent && (obj.agent.paused == true)) { obj.agent.paused = false; obj.agent.ws._socket.resume(); }
210
}
211
212
+ // Log leaving the multiplex session
213
+ if (obj.startTime != null) { // Used to check if the agent has connected. If not, don't log this event since the session never really started.
214
+ //var event = { etype: 'relay', action: 'relaylog', domain: domain.id, nodeid: obj.nodeid, userid: peer.user._id, username: peer.user.name, msgid: 5, msg: "Left the desktop multiplex session", protocol: 2 };
215
+ const sessionSeconds = Math.floor((Date.now() - peer.startTime) / 1000);
216
+ var event = { etype: 'relay', action: 'relaylog', domain: domain.id, nodeid: obj.nodeid, userid: peer.user._id, username: peer.user.name, msgid: 122, msgArgs: [sessionSeconds], msg: "Left the desktop multiplex session after " + sessionSeconds + " second(s).", protocol: 2 };
217
+ parent.parent.DispatchEvent(['*', obj.nodeid, peer.user._id, obj.meshid], obj, event);
218
+ }
219
+
220
// Aggressive clean up of the viewer
221
delete peer.desktopPaused;
222
delete peer.imageType;
@@ -219,12 +228,7 @@ function CreateDesktopMultiplexor(parent, domain, nodeid, func) {
228
delete peer.sending;
229
delete peer.overflow;
230
delete peer.sendQueue;
222
-
223
- // Log leaving the multiplex session
224
- if (obj.startTime != null) {
225
- var event = { etype: 'relay', action: 'relaylog', domain: domain.id, nodeid: obj.nodeid, userid: peer.user._id, username: peer.user.name, msgid: 5, msg: "Left the desktop multiplex session", protocol: 2 };
226
- parent.parent.DispatchEvent(['*', obj.nodeid, peer.user._id, obj.meshid], obj, event);
227
- }
231
+ delete peer.startTime;
232
233
// If this is the last viewer, disconnect the agent
234
if ((obj.viewers != null) && (obj.viewers.length == 0) && (obj.agent != null)) { obj.agent.close(); dispose(); return true; }
meshuser.js
+4
-3
@@ -5421,7 +5421,7 @@ module.exports.CreateMeshUser = function (parent, db, ws, req, args, domain, use
5421
5422
// Get the events in the time range
5423
// MySQL or MariaDB query will ignore the MsgID filter.
5424
- db.GetEventsTimeRange(ids, domain.id, [5, 10, 12], new Date(command.start * 1000), new Date(command.end * 1000), function (err, docs) {
5424
+ db.GetEventsTimeRange(ids, domain.id, [5, 10, 11, 12, 122], new Date(command.start * 1000), new Date(command.end * 1000), function (err, docs) {
5425
if (err != null) return;
5426
var data = { groups: {} };
5427
@@ -5438,7 +5438,7 @@ module.exports.CreateMeshUser = function (parent, db, ws, req, args, domain, use
5438
5439
// Rows
5440
for (var i in docs) {
5441
- if ((docs[i].msgid != 5) && (docs[i].msgid != 10) && (docs[i].msgid != 12)) continue; // If MySQL or MariaDB query, we can't filter on MsgID, so we have to do it here.
5441
+ if ((docs[i].msgid != 5) && (docs[i].msgid != 10) && (docs[i].msgid != 11) && (docs[i].msgid != 12) && (docs[i].msgid != 122)) continue; // If MySQL or MariaDB query, we can't filter on MsgID, so we have to do it here.
5442
5443
var entry = { time: docs[i].time.valueOf() };
5444
@@ -5448,7 +5448,8 @@ module.exports.CreateMeshUser = function (parent, db, ws, req, args, domain, use
5448
entry.protocol = docs[i].protocol;
5449
5450
// Session length
5451
- if (((docs[i].msgid == 10) || (docs[i].msgid == 12)) && (docs[i].msgArgs != null) && (typeof docs[i].msgArgs == 'object') && (typeof docs[i].msgArgs[3] == 'number')) { entry.length = docs[i].msgArgs[3]; }
5451
+ if (((docs[i].msgid >= 10) && (docs[i].msgid <= 12)) && (docs[i].msgArgs != null) && (typeof docs[i].msgArgs == 'object') && (typeof docs[i].msgArgs[3] == 'number')) { entry.length = docs[i].msgArgs[3]; }
5452
+ else if ((docs[i].msgid == 122) && (docs[i].msgArgs != null) && (typeof docs[i].msgArgs == 'object') && (typeof docs[i].msgArgs[0] == 'number')) { entry.length = docs[i].msgArgs[0]; }
5453
5454
if (command.groupBy == 1) { // Add entry to per user group
5455
if (data.groups[docs[i].userid] == null) { data.groups[docs[i].userid] = { entries: [] }; }
views/default.handlebars
+2
-1
@@ -12887,7 +12887,8 @@
12887
118: "This agent has an outstated certificate validation mechanism, consider updating.",
12888
119: "This agent is using insecure tunnels, consider updating.",
12889
120: "Started local relay session \"{0}\", protocol {1} to {2}",
12890
- 121: "Ended local relay session \"{0}\", protocol {1} to {2}, {3} second(s)"
12890
+ 121: "Ended local relay session \"{0}\", protocol {1} to {2}, {3} second(s)",
12891
+ 122: "Left the desktop multiplex session after {0} second(s).",
12892
};
12893
12894
// Highlights the device being hovered