Remove role="main" to ensure 'NPM Docs' page contains only one main landmark (#1354)
<!-- What / Why --> This pull request removes the `role="main"` attribute from the `PageElement` component in the `src/page.js` file to ensure there is only one main landmark on the 'NPM Docs' page. ## Before <img width="1725" alt="NPM Docs page with more than one main landmark" src="https://github.com/user-attachments/assets/dd397661-24a0-489b-813e-638e028c6242"> ## After <img width="1711" alt="NPM Docs page with only one main landmark" src="https://github.com/user-attachments/assets/86d300a1-d11c-4f0d-80e1-781566b5c106"> ## References - https://github.com/github/accessibility-audits/issues/9212
Mai TXN committed
Nov 5, 2024 at 09:40 UTC
21e36bbe22cc6587cbbd39e734a5e62c2e4b2343
1 file changed
+1
-1
src/page.js
+1
-1
@@ -35,7 +35,7 @@ const PageElement = ({element, props}) => {
35
<PageProvider value={page}>
36
<Box sx={{display: 'flex', flexDirection: 'column', minHeight: '100vh'}}>
37
<Header />
38
- <Box sx={{zIndex: 0, display: 'flex', flex: '1 1 auto', flexDirection: 'row'}} role="main">
38
+ <Box sx={{zIndex: 0, display: 'flex', flex: '1 1 auto', flexDirection: 'row'}}>
39
<Box sx={{display: ['none', null, null, 'block']}}>
40
<Sidebar />
41
</Box>