Bugfix 6054 aria labelledby select version (#773)
jpg619 committed
Oct 17, 2023 at 18:26 UTC
e7f56f2bd58f9e72de99cd36d779b4674200b47a
1 file changed
+5
-5
theme/src/components/variant-select.js
+5
-5
@@ -55,22 +55,22 @@ function VariantSelect(props) {
55
)
56
}
57
58
- const ariaLabelMenuButton = open ? 'Version release' : selectedItem.variant.title
58
+ // const ariaLabelMenuButton = open ? 'Version release' : selectedItem.variant.title
59
60
return (
61
<ThemeProvider>
62
- <label id="label-versions-list-item" htmlFor="versions-list-item">
62
+ <p id="label-versions-list-item">
63
Select CLI Version:
64
- </label>
64
+ </p>
65
<ActionMenu open={open} onOpenChange={setOpen}>
66
{/* Disabling to remove lint warnings. This property was added as "autofocus"
67
in a previous accessibility audit which did not trigger the lint warning. */
68
/* eslint-disable-next-line jsx-a11y/no-autofocus */}
69
- <ActionMenu.Button autoFocus aria-label={ariaLabelMenuButton}>
69
+ <ActionMenu.Button autoFocus aria-labelledby="label-versions-list-item">
70
{selectedItem.variant.title}
71
</ActionMenu.Button>
72
<ActionMenu.Overlay width="medium" onEscape={() => setOpen(false)}>
73
- <ActionList id="versions-list-item" aria-labelledby="label-versions-list-item">
73
+ <ActionList id="versions-list-item">
74
{items}
75
</ActionList>
76
</ActionMenu.Overlay>