fix: Display all items in large directories of S3 buckets
This is a follow-up to 9bc32f40207f02d1e6362715d4f19c16e0963457. The next marker value was not correctly retrieved and encoded so large folders are truncated. This issue can be seen on https://releases.nixos.org/?prefix=nixos/unstable/
Thomas Gerbet committed
Dec 21, 2025 at 17:39 UTC
b347cee5dfeb56a51c6d0b5d800c9c3cfd6ec8d8
1 file changed
+4
-3
terraform/s3_listing.html.tpl
+4
-3
@@ -154,7 +154,7 @@
154
155
html = typeof html !== 'undefined' ? html + prepareTable(info) :
156
prepareTable(info);
157
- if (info.nextMarker != "null") {
157
+ if (info.nextMarker !== null) {
158
getS3Data(info.nextMarker, html);
159
} else {
160
document.getElementById('listing').innerHTML =
@@ -250,8 +250,9 @@
250
}
251
// clang-format on
252
});
253
+ console.log($(xml.find('IsTruncated')[0]).text());
254
if ($(xml.find('IsTruncated')[0]).text() == 'true') {
254
- var nextMarker = xml.find('NextMarker').textContent;
255
+ var nextMarker = xml.find('NextMarker').text();
256
} else {
257
var nextMarker = null;
258
}
@@ -260,7 +261,7 @@
261
files: files,
262
directories: directories,
263
prefix: $(xml.find('Prefix')[0]).text(),
263
- nextMarker: encodeURIComponent(nextMarker)
264
+ nextMarker: nextMarker
265
}
266
// clang-format on
267
}