@cryptotaxi247 / kubo / commits / 0747b9cec

go-ipfs-config: gateway: enforce allowlist for path prefixes

The gateway accepts an X-Ipfs-Path-Prefix header, and assumes that it is mounted in a reverse proxy like nginx, at this path. Links in directory listings, as well as trailing-slash redirects need to be rewritten with that prefix in mind. We don't want a potential attacker to be able to pass in arbitrary path prefixes, which would end up in redirects and directory listings, which is why every prefix has to be explicitly allowed in the config. Previously, we'd accept *any* X-Ipfs-Path-Prefix header. Example: We mount blog.ipfs.io (a dnslink page) at ipfs.io/blog. nginx_ipfs.conf: location /blog/ { rewrite "^/blog(/.*)$" $1 break; proxy_set_header Host blog.ipfs.io; proxy_set_header X-Ipfs-Gateway-Prefix /blog; proxy_pass http://127.0.0.1:8080; } .ipfs/config: "Gateway": { "PathPrefixes": ["/blog"], // ... }, dnslink: > dig TXT _dnslink.blog.ipfs.io dnslink=/ipfs/QmWcBjXPAEdhXDATV4ghUpkAonNBbiyFx1VmmHcQe9HEGd License: MIT Signed-off-by: Lars Gierth <larsg@systemli.org>

Lars Gierth committed Mar 28, 2016 at 19:21 UTC 0747b9cecdc6b498fa7ef7f70c6e58e3e0546d2c

2 files changed +2

config/gateway.go

@@ -5,4 +5,5 @@ type Gateway struct {

5 HTTPHeaders map[string][]string // HTTP headers to return with the gateway

6 RootRedirect string

7 Writable bool

8 + PathPrefixes []string

9 }

config/init.go

@@ -65,6 +65,7 @@ func Init(out io.Writer, nBitsForKeypair int) (*Config, error) {

65 Gateway: Gateway{

66 RootRedirect: "",

67 Writable: false,

68 + PathPrefixes: []string{},

69 },

70 }