added test to not commit bad version numbers
Henry committed
Oct 18, 2014 at 14:32 UTC
1e623f8823157e2e7373bd662d043a66c4b375e7
2 files changed
+16
-2
updates/updates.go
+5
-2
@@ -35,13 +35,16 @@ var currentVersion *semver.Version
35
36
func init() {
37
var err error
38
- currentVersion, err = semver.NewVersion(Version)
38
+ currentVersion, err = parseVersion()
39
if err != nil {
40
- log.Error("The const Version literal in version.go needs to be in semver format: %s \n", Version)
40
+ log.Error("illegal version number in code: %q\n", Version)
41
os.Exit(1)
42
}
43
}
44
45
+func parseVersion() (*semver.Version, error) {
46
+ return semver.NewVersion(Version)
47
+}
48
func CheckForUpdates() error {
49
resp, err := http.Get(EndpointURLLatestReleases)
50
if err != nil {
updates/updates_test.go
new
+11
@@ -0,0 +1,11 @@
1
+package updates
2
+
3
+import "testing"
4
+
5
+// TestParseVersion just makes sure that we dont commit a bad version number
6
+func TestParseVersion(t *testing.T) {
7
+ _, err := parseVersion()
8
+ if err != nil {
9
+ t.Fatal(err)
10
+ }
11
+}