Golint: merkledag: let NewDagService return *dagService
License: MIT Signed-off-by: Hector Sanjuan <hector@protocol.ai>
Hector Sanjuan committed
Feb 7, 2018 at 00:35 UTC
2743dd246f1ebb18fc800040df0f091900f443e4
2 files changed
+4
-6
merkledag/merkledag.go
+1
-1
@@ -30,7 +30,7 @@ const progressContextKey contextKey = "progress"
30
31
// NewDAGService constructs a new DAGService (using the default implementation).
32
// Note that the default implementation is also an ipld.LinkGetter.
33
-func NewDAGService(bs bserv.BlockService) ipld.DAGService {
33
+func NewDAGService(bs bserv.BlockService) *dagService {
34
return &dagService{Blocks: bs}
35
}
36
merkledag/merkledag_test.go
+3
-5
@@ -242,8 +242,7 @@ func TestFetchGraph(t *testing.T) {
242
// create an offline dagstore and ensure all blocks were fetched
243
bs := bserv.New(bsis[1].Blockstore(), offline.Exchange(bsis[1].Blockstore()))
244
245
- // we know the default dagService implements LinkGetter
246
- offlineDS := NewDAGService(bs).(ipld.LinkGetter)
245
+ offlineDS := NewDAGService(bs)
246
247
err = EnumerateChildren(context.Background(), offlineDS.GetLinks, root.Cid(), func(_ *cid.Cid) bool { return true })
248
if err != nil {
@@ -262,9 +261,8 @@ func TestEnumerateChildren(t *testing.T) {
261
}
262
263
set := cid.NewSet()
265
- lg := ds.(ipld.LinkGetter)
264
267
- err = EnumerateChildren(context.Background(), lg.GetLinks, root.Cid(), set.Visit)
265
+ err = EnumerateChildren(context.Background(), ds.GetLinks, root.Cid(), set.Visit)
266
if err != nil {
267
t.Fatal(err)
268
}
@@ -495,7 +493,7 @@ func TestCidRetention(t *testing.T) {
493
}
494
495
func TestCidRawDoesnNeedData(t *testing.T) {
498
- srv := NewDAGService(dstest.Bserv()).(ipld.LinkGetter)
496
+ srv := NewDAGService(dstest.Bserv())
497
nd := NewRawNode([]byte("somedata"))
498
499
ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)