gateway: degrade most logging to debug level
License: MIT Signed-off-by: Lars Gierth <larsg@systemli.org>
Lars Gierth committed
Nov 26, 2017 at 03:37 UTC
55692ac9b631270afca30a4fc1ab9937df1cb9ce
1 file changed
+3
-6
core/corehttp/gateway_handler.go
+3
-6
@@ -119,7 +119,6 @@ func (i *gatewayHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
119
errmsg = errmsg + "bad request for " + r.URL.Path
120
}
121
fmt.Fprint(w, errmsg)
122
- log.Error(errmsg) // TODO(cryptix): log errors until we have a better way to expose these (counter metrics maybe)
122
}
123
124
func (i *gatewayHandler) optionsHandler(w http.ResponseWriter, r *http.Request) {
@@ -287,14 +286,11 @@ func (i *gatewayHandler) getOrHeadHandler(ctx context.Context, w http.ResponseWr
286
ixnd, err := dirr.Find(ctx, "index.html")
287
switch {
288
case err == nil:
290
- log.Debugf("found index.html link for %s", escapedURLPath)
291
-
289
dirwithoutslash := urlPath[len(urlPath)-1] != '/'
290
goget := r.URL.Query().Get("go-get") == "1"
291
if dirwithoutslash && !goget {
292
// See comment above where originalUrlPath is declared.
293
http.Redirect(w, r, originalUrlPath+"/", 302)
297
- log.Debugf("redirect to %s", originalUrlPath+"/")
294
return
295
}
296
@@ -510,7 +506,6 @@ func (i *gatewayHandler) putHandler(w http.ResponseWriter, r *http.Request) {
506
return
507
}
508
default:
513
- log.Warningf("putHandler: unhandled resolve error %T", ev)
509
webError(w, "could not resolve root DAG", ev, http.StatusInternalServerError)
510
return
511
}
@@ -618,8 +613,10 @@ func webError(w http.ResponseWriter, message string, err error, defaultCode int)
613
func webErrorWithCode(w http.ResponseWriter, message string, err error, code int) {
614
w.WriteHeader(code)
615
621
- log.Errorf("%s: %s", message, err) // TODO(cryptix): log until we have a better way to expose these (counter metrics maybe)
616
fmt.Fprintf(w, "%s: %s\n", message, err)
617
+ if code >= 500 {
618
+ log.Warningf("server error: %s: %s", err)
619
+ }
620
}
621
622
// return a 500 error and log