consolidate dns resolver constructors
The current convention is to return the concrete type instead of an interface so let's go with that and have one constructor. License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
Steven Allen committed
May 9, 2018 at 08:14 UTC
55cb76d4f360ccd35aadb0011f89eda4322212f3
2 files changed
+2
-8
namesys/dns.go
+1
-7
@@ -21,13 +21,7 @@ type DNSResolver struct {
21
}
22
23
// NewDNSResolver constructs a name resolver using DNS TXT records.
24
-func NewDNSResolver() Resolver {
25
- return &DNSResolver{lookupTXT: net.LookupTXT}
26
-}
27
-
28
-// newDNSResolver constructs a name resolver using DNS TXT records,
29
-// returning a resolver instead of NewDNSResolver's Resolver.
30
-func newDNSResolver() resolver {
24
+func NewDNSResolver() *DNSResolver {
25
return &DNSResolver{lookupTXT: net.LookupTXT}
26
}
27
namesys/namesys.go
+1
-1
@@ -35,7 +35,7 @@ type mpns struct {
35
func NewNameSystem(r routing.ValueStore, ds ds.Datastore, cachesize int) NameSystem {
36
return &mpns{
37
resolvers: map[string]resolver{
38
- "dns": newDNSResolver(),
38
+ "dns": NewDNSResolver(),
39
"proquint": new(ProquintResolver),
40
"dht": NewRoutingResolver(r, cachesize),
41
},