unexport functions
License: MIT Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
Brian Tiger Chow committed
Dec 16, 2014 at 23:43 UTC
6e7c46a6e29122df2f5837adcbd875eaf97b07f8
2 files changed
+7
-11
exchange/bitswap/decision/engine.go
+4
-8
@@ -160,17 +160,13 @@ func (e *Engine) MessageSent(p peer.Peer, m bsmsg.BitSwapMessage) error {
160
return nil
161
}
162
163
-func (e *Engine) NumBytesSentTo(p peer.Peer) uint64 {
164
- e.lock.RLock()
165
- defer e.lock.RUnlock()
166
-
163
+func (e *Engine) numBytesSentTo(p peer.Peer) uint64 {
164
+ // NB not threadsafe
165
return e.findOrCreate(p).Accounting.BytesSent
166
}
167
170
-func (e *Engine) NumBytesReceivedFrom(p peer.Peer) uint64 {
171
- e.lock.RLock()
172
- defer e.lock.RUnlock()
173
-
168
+func (e *Engine) numBytesReceivedFrom(p peer.Peer) uint64 {
169
+ // NB not threadsafe
170
return e.findOrCreate(p).Accounting.BytesRecv
171
}
172
exchange/bitswap/decision/engine_test.go
+3
-3
@@ -44,18 +44,18 @@ func TestConsistentAccounting(t *testing.T) {
44
}
45
46
// Ensure sender records the change
47
- if sender.Engine.NumBytesSentTo(receiver.Peer) == 0 {
47
+ if sender.Engine.numBytesSentTo(receiver.Peer) == 0 {
48
t.Fatal("Sent bytes were not recorded")
49
}
50
51
// Ensure sender and receiver have the same values
52
- if sender.Engine.NumBytesSentTo(receiver.Peer) != receiver.Engine.NumBytesReceivedFrom(sender.Peer) {
52
+ if sender.Engine.numBytesSentTo(receiver.Peer) != receiver.Engine.numBytesReceivedFrom(sender.Peer) {
53
t.Fatal("Inconsistent book-keeping. Strategies don't agree")
54
}
55
56
// Ensure sender didn't record receving anything. And that the receiver
57
// didn't record sending anything
58
- if receiver.Engine.NumBytesSentTo(sender.Peer) != 0 || sender.Engine.NumBytesReceivedFrom(receiver.Peer) != 0 {
58
+ if receiver.Engine.numBytesSentTo(sender.Peer) != 0 || sender.Engine.numBytesReceivedFrom(receiver.Peer) != 0 {
59
t.Fatal("Bert didn't send bytes to Ernie")
60
}
61
}