@cryptotaxi247 / kubo / commits / 7239036e2

clarify MessageReceived contract

License: MIT Signed-off-by: Brian Tiger Chow <brian@perfmode.com>

Brian Tiger Chow committed Nov 18, 2014 at 22:20 UTC 7239036e2d919c45241d8e346ce9e40f407c155f
1 file changed +3 -1
exchange/bitswap/strategy/strategy.go
+3 -1
@@ -72,6 +72,8 @@ func (s *strategist) Seed(int64) {
72 // TODO
73 }
74
75 +// MessageReceived performs book-keeping. Returns error if passed invalid
76 +// arguments.
77 func (s *strategist) MessageReceived(p peer.Peer, m bsmsg.BitSwapMessage) error {
78 s.lock.Lock()
79 defer s.lock.Unlock()
@@ -91,7 +93,7 @@ func (s *strategist) MessageReceived(p peer.Peer, m bsmsg.BitSwapMessage) error
93 // FIXME extract blocks.NumBytes(block) or block.NumBytes() method
94 l.ReceivedBytes(len(block.Data))
95 }
94 - return errors.New("TODO")
96 + return nil
97 }
98
99 // TODO add contents of m.WantList() to my local wantlist? NB: could introduce