test: make the test bit cleaner
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
Jakub Sztandera committed
Aug 16, 2016 at 12:49 UTC
a63b5c38b7c2b15e637d72e63849b35eb1c6508c
1 file changed
+12
-6
blocks/set/set_test.go
+12
-6
@@ -7,6 +7,12 @@ import (
7
k "github.com/ipfs/go-ipfs/blocks/key"
8
)
9
10
+const (
11
+ tAdd int = 1 << iota
12
+ tRemove
13
+ tReAdd
14
+)
15
+
16
func exampleKeys() []k.Key {
17
res := make([]k.Key, 1<<8)
18
gen := bu.NewBlockGenerator()
@@ -17,15 +23,15 @@ func exampleKeys() []k.Key {
23
}
24
func checkSet(set BlockSet, keySlice []k.Key, t *testing.T) {
25
for i, key := range keySlice {
20
- if i&(1<<2) == 0 {
26
+ if i&tReAdd == 0 {
27
if set.HasKey(key) == false {
28
t.Error("key should be in the set")
29
}
24
- } else if i&(1<<1) == 0 {
30
+ } else if i&tRemove == 0 {
31
if set.HasKey(key) == true {
32
t.Error("key shouldn't be in the set")
33
}
28
- } else if i&(1<<0) == 0 {
34
+ } else if i&tAdd == 0 {
35
if set.HasKey(key) == false {
36
t.Error("key should be in the set")
37
}
@@ -38,17 +44,17 @@ func TestSetWorks(t *testing.T) {
44
keys := exampleKeys()
45
46
for i, key := range keys {
41
- if i&(1<<0) == 0 {
47
+ if i&tAdd == 0 {
48
set.AddBlock(key)
49
}
50
}
51
for i, key := range keys {
46
- if i&(1<<1) == 0 {
52
+ if i&tRemove == 0 {
53
set.RemoveBlock(key)
54
}
55
}
56
for i, key := range keys {
51
- if (i)&(1<<2) == 0 {
57
+ if i&tReAdd == 0 {
58
set.AddBlock(key)
59
}
60
}