fix(2/pin) optionvalue signature
Brian Tiger Chow committed
Nov 12, 2014 at 00:06 UTC
a95dfdcf822ebe8f5373bd357d65fa903d4ce924
1 file changed
+14
-2
core/commands2/pin.go
+14
-2
@@ -34,7 +34,13 @@ on disk.
34
n := req.Context().Node
35
36
// set recursive flag
37
- recursive, _ := req.Option("recursive").Bool() // false if cast fails.
37
+ recursive, found, err := req.Option("recursive").Bool()
38
+ if err != nil {
39
+ return nil, err
40
+ }
41
+ if !found {
42
+ recursive = false
43
+ }
44
45
paths, err := internal.CastToStrings(req.Arguments())
46
if err != nil {
@@ -67,7 +73,13 @@ collected if needed.
73
n := req.Context().Node
74
75
// set recursive flag
70
- recursive, _ := req.Option("recursive").Bool() // false if cast fails.
76
+ recursive, found, err := req.Option("recursive").Bool()
77
+ if err != nil {
78
+ return nil, err
79
+ }
80
+ if !found {
81
+ recursive = false // default
82
+ }
83
84
paths, err := internal.CastToStrings(req.Arguments())
85
if err != nil {