refactor: remove redundant urlescape
URL.Query() will already decode the query parameters
Marcin Rataj committed
Dec 12, 2020 at 12:28 UTC
abb25a1cfc202ab4427bb1d3fa0c16d6e2700bd5
1 file changed
+1
-7
core/corehttp/gateway_handler.go
+1
-7
@@ -186,13 +186,7 @@ func (i *gatewayHandler) getOrHeadHandler(w http.ResponseWriter, r *http.Request
186
// https://developer.mozilla.org/en-US/docs/Web/API/Navigator/registerProtocolHandler
187
// TLDR: redirect /ipfs/?uri=ipfs%3A%2F%2Fcid%3Fquery%3Dval to /ipfs/cid?query=val
188
if uriParam := r.URL.Query().Get("uri"); uriParam != "" {
189
- // Browsers will pass URI in URL-escaped form, we need to unescape it first
190
- uri, err := url.QueryUnescape(uriParam)
191
- if err != nil {
192
- webError(w, "failed to unescape uri query parameter", err, http.StatusBadRequest)
193
- return
194
- }
195
- u, err := url.Parse(uri)
189
+ u, err := url.Parse(uriParam)
190
if err != nil {
191
webError(w, "failed to parse uri query parameter", err, http.StatusBadRequest)
192
return