Merge pull request #8965 from ipfs/schomatis/fix/disable-rcmg-checks
fix(node/libp2p): disable rcmgr checkImplicitDefaults (cherry picked from commit e23a4611d82e29ea6cbe3427b84c6e8f51ea3a28)
Lucas Molas committed
May 12, 2022 at 14:08 UTC
d8d7c215e8c091eb7d613fee1a2bec64bf7c81d9
2 files changed
+6
-1
.circleci/main.yml
+1
@@ -32,6 +32,7 @@ default_environment: &default_environment
32
CIRCLE_TEST_REPORTS: /tmp/circleci-test-results
33
CIRCLE_ARTIFACTS: /tmp/circleci-artifacts
34
GIT_PAGER: cat
35
+ IPFS_CHECK_RCMGR_DEFAULTS: 1
36
37
executors:
38
golang:
core/node/libp2p/rcmgr_defaults.go
+5
-1
@@ -4,6 +4,7 @@ import (
4
"encoding/json"
5
"fmt"
6
"math/bits"
7
+ "os"
8
"strings"
9
10
config "github.com/ipfs/go-ipfs/config"
@@ -19,7 +20,10 @@ import (
20
// such as values in Swarm.ConnMgr.HiWater config.
21
func adjustedDefaultLimits(cfg config.SwarmConfig) rcmgr.DefaultLimitConfig {
22
// Run checks to avoid introducing regressions
22
- checkImplicitDefaults()
23
+ if os.Getenv("IPFS_CHECK_RCMGR_DEFAULTS") != "" {
24
+ // FIXME: Broken. Being tracked in https://github.com/ipfs/go-ipfs/issues/8949.
25
+ checkImplicitDefaults()
26
+ }
27
28
// Return to use unmodified static limits based on values from go-libp2p 0.18
29
// return defaultLimits