core/commands/publish: Fix published message
Previously we had a confusing situation, with: * single-arg doc: published name <name> to <value> * double-arg doc: published name <value> to <name> * implementation: Published name <name> to <value> Now we have the uniform: Published to <name>: <value> With the following goals: 1. It's clear that we're writing <value> to <name>'s IPNS slot in the DHT. 2. We preserve the order of arguments from the command-line invocation: $ ipfs name publish <name> <value> Published to <name>: <value>
W. Trevor King committed
May 7, 2015 at 20:58 UTC
e4447b3c961eb874d50476957236102335feca9b
3 files changed
+14
-13
core/commands/name.go
+6
-6
@@ -27,15 +27,15 @@ and resolve, the default value of <name> is your own identity public key.
27
28
Examples:
29
30
-Publish a <ref> to your identity name:
30
+Publish an <ipfs-path> to your identity name:
31
32
- > ipfs name publish QmatmE9msSfkKxoffpHwNLNKgwZG8eT9Bud6YoPab52vpy
33
- published name QmbCMUZw6JFeZ7Wp9jkzbye3Fzp2GGcPgC3nmeUjfVF87n to QmatmE9msSfkKxoffpHwNLNKgwZG8eT9Bud6YoPab52vpy
32
+ > ipfs name publish /ipfs/QmatmE9msSfkKxoffpHwNLNKgwZG8eT9Bud6YoPab52vpy
33
+ Published to QmbCMUZw6JFeZ7Wp9jkzbye3Fzp2GGcPgC3nmeUjfVF87n: /ipfs/QmatmE9msSfkKxoffpHwNLNKgwZG8eT9Bud6YoPab52vpy
34
35
-Publish a <ref> to another public key:
35
+Publish an <ipfs-path> to another public key:
36
37
- > ipfs name publish QmbCMUZw6JFeZ7Wp9jkzbye3Fzp2GGcPgC3nmeUjfVF87n QmatmE9msSfkKxoffpHwNLNKgwZG8eT9Bud6YoPab52vpy
38
- published name QmbCMUZw6JFeZ7Wp9jkzbye3Fzp2GGcPgC3nmeUjfVF87n to QmatmE9msSfkKxoffpHwNLNKgwZG8eT9Bud6YoPab52vpy
37
+ > ipfs name publish /ipfs/QmatmE9msSfkKxoffpHwNLNKgwZG8eT9Bud6YoPab52vpy QmbCMUZw6JFeZ7Wp9jkzbye3Fzp2GGcPgC3nmeUjfVF87n
38
+ Published to QmbCMUZw6JFeZ7Wp9jkzbye3Fzp2GGcPgC3nmeUjfVF87n: /ipfs/QmatmE9msSfkKxoffpHwNLNKgwZG8eT9Bud6YoPab52vpy
39
40
Resolve the value of your identity:
41
core/commands/publish.go
+5
-4
@@ -35,12 +35,13 @@ Examples:
35
Publish an <ipfs-path> to your identity name:
36
37
> ipfs name publish /ipfs/QmatmE9msSfkKxoffpHwNLNKgwZG8eT9Bud6YoPab52vpy
38
- published name QmbCMUZw6JFeZ7Wp9jkzbye3Fzp2GGcPgC3nmeUjfVF87n to QmatmE9msSfkKxoffpHwNLNKgwZG8eT9Bud6YoPab52vpy
38
+ Published to QmbCMUZw6JFeZ7Wp9jkzbye3Fzp2GGcPgC3nmeUjfVF87n: /ipfs/QmatmE9msSfkKxoffpHwNLNKgwZG8eT9Bud6YoPab52vpy
39
40
Publish an <ipfs-path> to another public key (not implemented):
41
42
- > ipfs name publish QmbCMUZw6JFeZ7Wp9jkzbye3Fzp2GGcPgC3nmeUjfVF87n QmatmE9msSfkKxoffpHwNLNKgwZG8eT9Bud6YoPab52vpy
43
- published name QmbCMUZw6JFeZ7Wp9jkzbye3Fzp2GGcPgC3nmeUjfVF87n to QmatmE9msSfkKxoffpHwNLNKgwZG8eT9Bud6YoPab52vpy
42
+ > ipfs name publish /ipfs/QmatmE9msSfkKxoffpHwNLNKgwZG8eT9Bud6YoPab52vpy QmbCMUZw6JFeZ7Wp9jkzbye3Fzp2GGcPgC3nmeUjfVF87n
43
+ Published to QmbCMUZw6JFeZ7Wp9jkzbye3Fzp2GGcPgC3nmeUjfVF87n: /ipfs/QmatmE9msSfkKxoffpHwNLNKgwZG8eT9Bud6YoPab52vpy
44
+
45
`,
46
},
47
@@ -102,7 +103,7 @@ Publish an <ipfs-path> to another public key (not implemented):
103
Marshalers: cmds.MarshalerMap{
104
cmds.Text: func(res cmds.Response) (io.Reader, error) {
105
v := res.Output().(*IpnsEntry)
105
- s := fmt.Sprintf("Published name %s to %s\n", v.Name, v.Value)
106
+ s := fmt.Sprintf("Published to %s: %s\n", v.Name, v.Value)
107
return strings.NewReader(s), nil
108
},
109
},
test/sharness/t0100-name.sh
+3
-3
@@ -14,11 +14,11 @@ test_init_ipfs
14
15
test_expect_success "'ipfs name publish' succeeds" '
16
PEERID=`ipfs id --format="<id>"` &&
17
- ipfs name publish "$HASH_WELCOME_DOCS" >publish_out
17
+ ipfs name publish "/ipfs/$HASH_WELCOME_DOCS" >publish_out
18
'
19
20
test_expect_success "publish output looks good" '
21
- echo "Published name $PEERID to /ipfs/$HASH_WELCOME_DOCS" >expected1 &&
21
+ echo "Published to ${PEERID}: /ipfs/$HASH_WELCOME_DOCS" >expected1 &&
22
test_cmp publish_out expected1
23
'
24
@@ -39,7 +39,7 @@ test_expect_success "'ipfs name publish' succeeds" '
39
'
40
41
test_expect_success "publish a path looks good" '
42
- echo "Published name $PEERID to /ipfs/$HASH_WELCOME_DOCS/help" >expected3 &&
42
+ echo "Published to ${PEERID}: /ipfs/$HASH_WELCOME_DOCS/help" >expected3 &&
43
test_cmp publish_out expected3
44
'
45