@cryptotaxi247 / kubo / commits / e66e8bbe9

Corenet API: Review fixes

License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>

Łukasz Magiera committed Jun 1, 2017 at 20:11 UTC e66e8bbe964c7b0eb6feb592023bfcd0898fabd1
2 files changed +8 -11
core/commands/corenet.go
+7 -10
@@ -465,7 +465,7 @@ var corenetCloseCmd = &cmds.Command{
465 useHandlerID := false
466
467 if !closeAll && len(req.Arguments()) == 0 {
468 - res.SetError(errors.New(" handlerID nor stream protocol"), cmds.ErrNormal)
468 + res.SetError(errors.New("no handlerID nor stream protocol specified"), cmds.ErrNormal)
469 return
470
471 } else if !closeAll {
@@ -479,11 +479,11 @@ var corenetCloseCmd = &cmds.Command{
479 }
480
481 if closeAll || useHandlerID {
482 - for _, s := range n.Corenet.Streams.Streams {
483 - if !closeAll && handlerID != s.HandlerID {
482 + for _, stream := range n.Corenet.Streams.Streams {
483 + if !closeAll && handlerID != stream.HandlerID {
484 continue
485 }
486 - s.Close()
486 + stream.Close()
487 if !closeAll {
488 break
489 }
@@ -491,19 +491,16 @@ var corenetCloseCmd = &cmds.Command{
491 }
492
493 if closeAll || !useHandlerID {
494 - for _, a := range n.Corenet.Apps.Apps {
495 - if !closeAll && a.Protocol != proto {
494 + for _, app := range n.Corenet.Apps.Apps {
495 + if !closeAll && app.Protocol != proto {
496 continue
497 }
498 - a.Close()
498 + app.Close()
499 if !closeAll {
500 break
501 }
502 }
503 }
504 -
505 - if len(req.Arguments()) != 1 {
506 - }
504 },
505 }
506
core/commands/root.go
+1 -1
@@ -47,7 +47,7 @@ ADVANCED COMMANDS
47 pin Pin objects to local storage
48 repo Manipulate the IPFS repository
49 stats Various operational stats
50 - exp Experimental commands
50 + corenet Libp2p stream mounting
51 filestore Manage the filestore (experimental)
52
53 NETWORK COMMANDS