@cryptotaxi247 / kubo / commits / e6c5fc250

docs(commands) todo

License: MIT Signed-off-by: Brian Tiger Chow <brian@perfmode.com>

Brian Tiger Chow committed Nov 12, 2014 at 23:53 UTC e6c5fc250c8de0563b32b9832964f0cbfce796bc
1 file changed +4 -1
commands/cli/parse.go
+4 -1
@@ -160,7 +160,10 @@ func argValue(argDef cmds.Argument, value string) (interface{}, error) {
160 return value, nil
161
162 } else {
163 - in, err := os.Open(value) // FIXME(btc) must close file. fix before merge
163 + // NB At the time of this commit, file cleanup is performed when
164 + // Requests are cleaned up. TODO try to perform open and close at the
165 + // same level of abstraction (or at least in the same package!)
166 + in, err := os.Open(value)
167 if err != nil {
168 return nil, err
169 }