Moved Tests up in Contribute.md
This should be more prominent. We also need a much better description of how to run tests - rigt now, we are dependant on Travis for the majority of testing, I believe. If there was a clear guide here on how to run the appropriate tests for each kind of PR, that would be fantastic. We also really ought to have a section asking people to add all of the tests that they can think of. License: MIT Signed-off-by: Richard Littauer <richard.littauer@gmail.com>
Richard Littauer committed
May 10, 2016 at 16:44 UTC
f33a3a0904f371890da8c677bb4cc7fbc2ef1a04
1 file changed
+4
-5
contribute.md
+4
-5
@@ -19,6 +19,10 @@ Please look and conform to our [Go Contribution Guidelines](https://github.com/i
19
20
## Repository specific guidelines:
21
22
+### Each Commit Must Pass Tests
23
+
24
+All commits in a PR must pass tests. If they don't, fix the commits and/or [squash them](https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History#Squashing-Commits) so that they do pass the tests. This should be done so that we can use git-bisect easily.
25
+
26
### Commit messages
27
28
Commit messages must start with a short subject line, followed by an optional,
@@ -90,8 +94,3 @@ reasons why this is _the right thing to do_:
94
License: MIT
95
Signed-off-by: Juan Benet <juan@ipfs.io>
96
```
93
-
94
-### Each Commit Must Pass Tests
95
-
96
-All commits in a PR must pass tests. If they don't, fix the commits and/or [squash them](https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History#Squashing-Commits) so that they do pass the tests. This should be done so that we can use git-bisect easily.
97
-