resolve: recurse by default
This is what users expect. fixes #5635 fixes #5585 fixes #4181 fixes #4293 fixes #6086 License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
Steven Allen committed
Mar 15, 2019 at 19:20 UTC
fded3bc08ca5629e9494f74e1f76338e2de4797c
3 files changed
+3
-3
core/commands/dns.go
+1
-1
@@ -58,7 +58,7 @@ The resolver can recursively resolve:
58
cmdkit.StringArg("domain-name", true, false, "The domain-name name to resolve.").EnableStdin(),
59
},
60
Options: []cmdkit.Option{
61
- cmdkit.BoolOption(dnsRecursiveOptionName, "r", "Resolve until the result is not a DNS link."),
61
+ cmdkit.BoolOption(dnsRecursiveOptionName, "r", "Resolve until the result is not a DNS link.").WithDefault(true),
62
},
63
Run: func(req *cmds.Request, res cmds.ResponseEmitter, env cmds.Environment) error {
64
recursive, _ := req.Options[dnsRecursiveOptionName].(bool)
core/commands/name/ipns.go
+1
-1
@@ -73,7 +73,7 @@ Resolve the value of a dnslink:
73
cmdkit.StringArg("name", false, false, "The IPNS name to resolve. Defaults to your node's peerID."),
74
},
75
Options: []cmdkit.Option{
76
- cmdkit.BoolOption(recursiveOptionName, "r", "Resolve until the result is not an IPNS name."),
76
+ cmdkit.BoolOption(recursiveOptionName, "r", "Resolve until the result is not an IPNS name.").WithDefault(true),
77
cmdkit.BoolOption(nocacheOptionName, "n", "Do not use cached entries."),
78
cmdkit.UintOption(dhtRecordCountOptionName, "dhtrc", "Number of records to request for DHT resolution."),
79
cmdkit.StringOption(dhtTimeoutOptionName, "dhtt", "Max time to collect values during DHT resolution eg \"30s\". Pass 0 for no timeout."),
core/commands/resolve.go
+1
-1
@@ -70,7 +70,7 @@ Resolve the value of an IPFS DAG path:
70
cmdkit.StringArg("name", true, false, "The name to resolve.").EnableStdin(),
71
},
72
Options: []cmdkit.Option{
73
- cmdkit.BoolOption(resolveRecursiveOptionName, "r", "Resolve until the result is an IPFS name."),
73
+ cmdkit.BoolOption(resolveRecursiveOptionName, "r", "Resolve until the result is an IPFS name.").WithDefault(true),
74
cmdkit.IntOption(resolveDhtRecordCountOptionName, "dhtrc", "Number of records to request for DHT resolution."),
75
cmdkit.StringOption(resolveDhtTimeoutOptionName, "dhtt", "Max time to collect values during DHT resolution eg \"30s\". Pass 0 for no timeout."),
76
},