0cc327f9f · cryptotaxi247/netdata-1

collectors/log2journal/log2journal-replace.c

+2

@@ -74,6 +74,7 @@ bool replace_pattern_set(REPLACE_PATTERN *rp, const char *pattern) {

74 log2stderr("Error: Failed to add replacement node for variable.");

75 return false;

76 }

77 + freez(variable_name);

78

79 current = end + 1; // Move past the variable

80 }

@@ -97,6 +98,7 @@ bool replace_pattern_set(REPLACE_PATTERN *rp, const char *pattern) {

98 log2stderr("Error: Failed to add replacement node for text.");

99 return false;

100 }

101 + freez(text);

102 }

103 }

104

collectors/log2journal/log2journal-yaml.c

+2

@@ -561,6 +561,8 @@ static size_t yaml_parse_rewrites(yaml_parser_t *parser, LOG_JOB *jb) {

561

562 yaml_event_delete(&sub_event);

563 }

564 + freez(replace_pattern);

565 + replace_pattern = NULL;

566 }

567 break;

568

logsmanagement/parser.c

-1

@@ -226,7 +226,6 @@ int search_keyword( char *src, size_t src_sz __maybe_unused,

226 size_t regcomp_err_str_size = regerror(rc, &regex_compiled, 0, 0);

227 char *regcomp_err_str = mallocz(regcomp_err_str_size);

228 regerror(rc, &regex_compiled, regcomp_err_str, regcomp_err_str_size);

229 - freez(regcomp_err_str);

229 fatal("Could not compile regular expression:%.*s, error: %s", (int) MAX_REGEX_SIZE, regexString, regcomp_err_str);

230 }

231 }

logsmanagement/query.c

+2 -2

@@ -95,8 +95,8 @@ const logs_qry_res_err_t *fetch_log_sources(BUFFER *wb){

95 buffer_json_member_add_string(wb, "filename", p_file_infos_arr->data[i]->filename);

96 buffer_json_member_add_string(wb, "log_type", log_src_type_t_str[p_file_infos_arr->data[i]->log_type]);

97 buffer_json_member_add_string(wb, "db_dir", p_file_infos_arr->data[i]->db_dir);

98 - buffer_json_member_add_uint64(wb, "db_version", db_user_version(p_file_infos_arr->data[i]->db, -1));

99 - buffer_json_member_add_uint64(wb, "db_flush_freq", db_user_version(p_file_infos_arr->data[i]->db, -1));

98 + buffer_json_member_add_int64(wb, "db_version", db_user_version(p_file_infos_arr->data[i]->db, -1));

99 + buffer_json_member_add_int64(wb, "db_flush_freq", db_user_version(p_file_infos_arr->data[i]->db, -1));

100 buffer_json_member_add_int64( wb, "db_disk_space_limit", p_file_infos_arr->data[i]->blob_max_size * BLOB_MAX_FILES);

101 buffer_json_object_close(wb); // options object

102 }

logsmanagement/unit_test/unit_test.c

+3

@@ -169,6 +169,7 @@ static int test_compression_decompression() {

169 fprintf(stderr, "- Error, original and decompressed data not the same\n");

170 ++errors;

171 }

172 + freez(decompressed_text);

173

174 fprintf(stderr, "%s\n", errors ? "FAIL" : "OK");

175 return errors;

@@ -183,6 +184,7 @@ static int test_read_last_line() {

184 #else

185 char tmpname[] = "/tmp/tmp.XXXXXX";

186 #endif

187 + (void) umask(0022);

188

189 int fd = mkstemp(tmpname);

190 if (fd == -1){

@@ -219,6 +221,7 @@ static int test_read_last_line() {

221

222 unlink(tmpname);

223 close(fd);

224 + fclose(tmpfp);

225

226 fprintf(stderr, "%s\n", errors ? "FAIL" : "OK");

227 return errors;

Fix coverity issues (#16655)