megacli: remove call to battery info on every iter if it fails on check
lgz committed
Jul 6, 2018 at 18:01 UTC
0d27f5313c9f5a7aaa0654a74de0d638a7fe7e97
1 file changed
+4
-3
python.d/megacli.chart.py
+4
-3
@@ -206,17 +206,18 @@ class Service(ExecutableService):
206
def check_battery(self):
207
d = self._get_raw_data(command=self.megacli.battery_info)
208
if not d:
209
- return
209
+ return False
210
211
bats = find_batteries(d)
212
213
if not bats:
214
self.error('failed to parse "{0}" output'.format(' '.join(self.megacli.battery_info)))
215
- return
215
+ return False
216
217
o, c = battery_charts(bats)
218
self.order.extend(o)
219
self.definitions.update(c)
220
+ return True
221
222
def check(self):
223
if not self.megacli:
@@ -227,7 +228,7 @@ class Service(ExecutableService):
228
return False
229
230
if self.do_battery:
230
- self.check_battery()
231
+ self.do_battery = self.check_battery()
232
233
return True
234