Fix memory leak during host chart label cleanup (#16568)
Fix memory leak
Stelios Fragkakis committed
Dec 8, 2023 at 10:00 UTC
0d3c9beda381fd8a6d5ff4e8f1001bc3e40ae822
1 file changed
+5
-6
database/sqlite/sqlite_metadata.c
+5
-6
@@ -1474,12 +1474,11 @@ static void start_metadata_hosts(uv_work_t *req __maybe_unused)
1474
char *machine_guid = *PValue;
1475
1476
host = rrdhost_find_by_guid(machine_guid);
1477
- if (unlikely(host))
1478
- continue;
1479
-
1480
- uuid_t host_uuid;
1481
- if (!uuid_parse(machine_guid, host_uuid))
1482
- delete_host_chart_labels(&host_uuid);
1477
+ if (likely(!host)) {
1478
+ uuid_t host_uuid;
1479
+ if (!uuid_parse(machine_guid, host_uuid))
1480
+ delete_host_chart_labels(&host_uuid);
1481
+ }
1482
1483
freez(machine_guid);
1484
}