Explicitly disable logsmanagement plugin on known-broken environments. (#18002)
* Explicitly disable logsmanagement plugin on known-broken environments. Also, just disable it by default, because we don’t really support it. * Fix logic for disabling logs management plugin.
Austin S. Hemmelgarn committed
Jun 26, 2024 at 06:59 UTC
1440750413afdfced6af0cdc5679fbfef442dd84
1 file changed
+7
-1
CMakeLists.txt
+7
-1
@@ -90,6 +90,7 @@ set(OS_FREEBSD False)
90
set(OS_LINUX False)
91
set(OS_MACOS False)
92
set(OS_WINDOWS False)
93
+set(ALLOW_PLATFORM_SENSITIVE_OPTIONS True)
94
95
if("${CMAKE_SYSTEM_NAME}" STREQUAL "Darwin")
96
set(OS_MACOS True)
@@ -103,6 +104,11 @@ elseif("${CMAKE_SYSTEM_NAME}" STREQUAL "Linux")
104
set(OS_LINUX True)
105
add_definitions(-D_GNU_SOURCE)
106
message(INFO " Compiling for Linux... ")
107
+ include(NetdataUtil)
108
+ netdata_identify_libc(LIBC_IMPLEMENTATION)
109
+ if(CMAKE_C_COMPILER_ID STREQUAL "Clang" AND LIBC_IMPLEMENTATION STREQUAL "musl")
110
+ set(ALLOW_PLATFORM_SENSITIVE_OPTIONS False)
111
+ endif()
112
elseif("${CMAKE_SYSTEM_NAME}" STREQUAL "CYGWIN" OR "${CMAKE_SYSTEM_NAME}" STREQUAL "MSYS" OR "${CMAKE_SYSTEM_NAME}" STREQUAL "Windows")
113
set(OS_WINDOWS True)
114
add_definitions(-D_GNU_SOURCE)
@@ -151,7 +157,7 @@ cmake_dependent_option(ENABLE_PLUGIN_EBPF "Enable Linux eBPF metric collection"
157
cmake_dependent_option(ENABLE_LEGACY_EBPF_PROGRAMS "Enable eBPF programs for kernels without BTF support" True "ENABLE_PLUGIN_EBPF" False)
158
mark_as_advanced(ENABLE_LEGACY_EBPF_PROGRAMS)
159
cmake_dependent_option(ENABLE_PLUGIN_LOCAL_LISTENERS "Enable local listening socket tracking (including service auto-discovery support)" ${DEFAULT_FEATURE_STATE} "OS_LINUX" False)
154
-cmake_dependent_option(ENABLE_PLUGIN_LOGS_MANAGEMENT "Enable log collection and monitoring based on Fluent Bit" ${DEFAULT_FEATURE_STATE} "OS_LINUX" False)
160
+cmake_dependent_option(ENABLE_PLUGIN_LOGS_MANAGEMENT "Enable log collection and monitoring based on Fluent Bit" False "OS_LINUX AND ALLOW_PLATFORM_SENSITIVE_OPTIONS" False)
161
cmake_dependent_option(ENABLE_PLUGIN_NETWORK_VIEWER "Enable network viewer functionality" ${DEFAULT_FEATURE_STATE} "OS_LINUX" False)
162
cmake_dependent_option(ENABLE_PLUGIN_NFACCT "Enable Linux NFACCT metric collection" ${DEFAULT_FEATURE_STATE} "OS_LINUX" False)
163
cmake_dependent_option(ENABLE_PLUGIN_PERF "Enable Linux performance counter monitoring" ${DEFAULT_FEATURE_STATE} "OS_LINUX" False)