updater: handle json decode error in newer_commit_date() (#17925)
Ilya Mashchenko committed
Jun 17, 2024 at 15:28 UTC
145df7a80113c51366005054be9c73e5009f2214
1 file changed
+11
-1
packaging/installer/netdata-updater.sh
+11
-1
@@ -533,7 +533,17 @@ newer_commit_date() {
533
info "Checking if a newer version of the updater script is available."
534
535
commit_check_url="https://api.github.com/repos/netdata/netdata/commits?path=packaging%2Finstaller%2Fnetdata-updater.sh&page=1&per_page=1"
536
- python_version_check="from __future__ import print_function;import sys,json;data = json.load(sys.stdin);print(data[0]['commit']['committer']['date'] if isinstance(data, list) else '')"
536
+ python_version_check="
537
+from __future__ import print_function
538
+import sys, json
539
+
540
+try:
541
+ data = json.load(sys.stdin)
542
+except:
543
+ print('')
544
+else:
545
+ print(data[0]['commit']['committer']['date'] if isinstance(data, list) and data else '')
546
+"
547
548
if command -v jq > /dev/null 2>&1; then
549
commit_date="$(_safe_download "${commit_check_url}" /dev/stdout | jq '.[0].commit.committer.date' 2>/dev/null | tr -d '"')"