Fix coverity issues (#15375)
* parser cannot be null -- CID 394449 Dereference before null check (REVERSE_INULL) * Fix warning - ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
Stelios Fragkakis committed
Jul 12, 2023 at 21:28 UTC
15e15d0f24fd0f6122a367db9efd93c2aa8c1146
2 files changed
+5
-3
claim/claim.c
+4
-2
@@ -257,8 +257,10 @@ bool netdata_random_session_id_generate(void) {
257
if (write(fd, guid, UUID_STR_LEN - 1) != UUID_STR_LEN - 1) {
258
netdata_log_error("Cannot write the random session id file '%s'.", filename);
259
ret = false;
260
- } else
261
- (void) write(fd, "\n", 1);
260
+ } else {
261
+ ssize_t bytes = write(fd, "\n", 1);
262
+ UNUSED(bytes);
263
+ }
264
close(fd);
265
}
266
streaming/receiver.c
+1
-1
@@ -363,7 +363,7 @@ static size_t streaming_parser(struct receiver_state *rpt, struct plugind *cd, i
363
}
364
}
365
366
- result = parser ? parser->user.data_collections_count : 0;
366
+ result = parser->user.data_collections_count;
367
368
// free parser with the pop function
369
netdata_thread_cleanup_pop(1);