wrapping for..in loop in a filter that removes unwanted properties according to codaclimate
BrainDoctor committed
Jul 20, 2017 at 20:47 UTC
27fd190670912da0890a027ff39f95dc16cd5b81
1 file changed
+8
-4
node.d/fronius.node.js
+8
-4
@@ -179,9 +179,11 @@ var fronius = {
179
180
var dim = {};
181
for (var key in inverters) {
182
- var name = key;
183
- if (!isNaN(key)) name = "Inverter " + key;
184
- dim[key] = this.createBasicDimension("inverter_" + key, name, 1);
182
+ if (inverters.hasOwnProperty(key)) {
183
+ var name = key;
184
+ if (!isNaN(key)) name = "Inverter " + key;
185
+ dim[key] = this.createBasicDimension("inverter_" + key, name, 1);
186
+ }
187
}
188
189
chart = {
@@ -276,7 +278,9 @@ var fronius = {
278
parseInverterChart: function (service, inverters) {
279
var dimensions = [];
280
for (var key in inverters) {
279
- dimensions.push(this.getDimension(key, Math.round(inverters[key].P)));
281
+ if (inverters.hasOwnProperty(key)) {
282
+ dimensions.push(this.getDimension(key, Math.round(inverters[key].P)));
283
+ }
284
}
285
return this.getChart(this.getInverterPowerChart(service, "inverters.output", inverters), dimensions);
286
},