go.d zfspool minor schema and meta fixes (#17372)
Ilya Mashchenko committed
Apr 11, 2024 at 10:30 UTC
2da14f9da4e46039859ce17481ad6f9b8e91aade
3 files changed
+9
-3
src/go/collectors/go.d.plugin/modules/intelgpu/intelgpu_test.go
+6
@@ -7,6 +7,8 @@ import (
7
"os"
8
"testing"
9
10
+ "github.com/netdata/netdata/go/go.d.plugin/agent/module"
11
+
12
"github.com/stretchr/testify/assert"
13
"github.com/stretchr/testify/require"
14
)
@@ -28,6 +30,10 @@ func Test_testDataIsValid(t *testing.T) {
30
}
31
}
32
33
+func TestIntelGPU_ConfigurationSerialize(t *testing.T) {
34
+ module.TestConfigurationSerialize(t, &IntelGPU{}, dataConfigJSON, dataConfigYAML)
35
+}
36
+
37
func TestIntelGPU_Init(t *testing.T) {
38
tests := map[string]struct {
39
prepare func(igt *IntelGPU)
src/go/collectors/go.d.plugin/modules/zfspool/config_schema.json
+2
-2
@@ -15,14 +15,14 @@
15
"title": "Binary path",
16
"description": "Path to the `zpool` binary.",
17
"type": "string",
18
- "default": "nvme"
18
+ "default": "/usr/bin/zpool"
19
},
20
"timeout": {
21
"title": "Timeout",
22
"description": "Timeout for executing the binary, specified in seconds.",
23
"type": "number",
24
"minimum": 0.5,
25
- "default": 10
25
+ "default": 2
26
}
27
},
28
"required": [
src/go/collectors/go.d.plugin/modules/zfspool/metadata.yaml
+1
-1
@@ -82,7 +82,7 @@ modules:
82
alerts:
83
- name: zfs_pool_space_utilization
84
metric: zfspool.pool_space_utilization
85
- info: "ZFS pool **${label:pool}** is nearing capacity. Current space usage is above the threshold."
85
+ info: "ZFS pool ${label:pool} is nearing capacity. Current space usage is above the threshold."
86
link: https://github.com/netdata/netdata/blob/master/src/health/health.d/zfs.conf
87
- name: zfs_pool_health_state_warn
88
metric: zfspool.pool_health_state