replace list comp with filter
Ilya committed
Jan 10, 2017 at 09:50 UTC
317d39eb39aae16e3f858a2c6fd7f58c4909b9c2
1 file changed
+8
-4
python.d/haproxy.chart.py
+8
-4
@@ -87,10 +87,8 @@ class Service(UrlService):
87
88
all_instances = [dict(zip(raw_data[0].split(','), raw_data[_].split(','))) for _ in range(1, len(raw_data))]
89
90
- back_ends = [backend for backend in all_instances
91
- if backend['svname'] == 'BACKEND' and backend['# pxname'] != 'stats']
92
- front_ends = [frontend for frontend in all_instances
93
- if frontend['svname'] == 'FRONTEND' and frontend['# pxname'] != 'stats']
90
+ back_ends = list(filter(is_backend, all_instances))
91
+ front_ends = list(filter(is_frontend, all_instances))
92
93
if self.charts:
94
self.create_charts(front_ends, back_ends)
@@ -107,3 +105,9 @@ class Service(UrlService):
105
to_netdata.update({'_'.join([_, backend['# pxname']]): int(backend[_[1:]]) if backend.get(_[1:]) else 0})
106
107
return to_netdata
108
+
109
+def is_backend(backend):
110
+ return backend['svname'] == 'BACKEND' and backend['# pxname'] != 'stats'
111
+
112
+def is_frontend(frontend):
113
+ return frontend['svname'] == 'FRONTEND' and frontend['# pxname'] != 'stats'