fix(go.d/sensors): ignore 'unknown' values (#18806)
Ilya Mashchenko committed
Oct 17, 2024 at 18:29 UTC
393c7b3de9c556e7d2bccaec5f237c4d775827e5
2 files changed
+6
-2
src/go/plugin/go.d/modules/sensors/lmsensors/scanner.go
+5
@@ -80,6 +80,11 @@ func (sc *Scanner) Scan() ([]*Chip, error) {
80
continue
81
}
82
83
+ // power average_max can be unknown (https://github.com/netdata/netdata/issues/18805)
84
+ if content == "unknown" && subfeat != "label" {
85
+ continue
86
+ }
87
+
88
if _, ok := rawSns[feat]; !ok {
89
rawSns[feat] = make(map[string]rawValue)
90
}
src/go/plugin/go.d/modules/sensors/lmsensors/scanner_test.go
+1
-2
@@ -33,7 +33,6 @@ func TestScanner_Scan(t *testing.T) {
33
Average: ptr(345.0),
34
AverageHighest: ptr(345.0),
35
AverageLowest: ptr(345.0),
36
- AverageMax: ptr(345.0),
36
AverageMin: ptr(345.0),
37
Input: ptr(345.0),
38
InputHighest: ptr(345.0),
@@ -66,7 +65,7 @@ func TestScanner_Scan(t *testing.T) {
65
{name: "/sys/devices/LNXSYSTM:00/device:00/ACPI0000:00/power1_average", val: "345000000"},
66
{name: "/sys/devices/LNXSYSTM:00/device:00/ACPI0000:00/power1_average_highest", val: "345000000"},
67
{name: "/sys/devices/LNXSYSTM:00/device:00/ACPI0000:00/power1_average_lowest", val: "345000000"},
69
- {name: "/sys/devices/LNXSYSTM:00/device:00/ACPI0000:00/power1_average_max", val: "345000000"},
68
+ {name: "/sys/devices/LNXSYSTM:00/device:00/ACPI0000:00/power1_average_max", val: "unknown"},
69
{name: "/sys/devices/LNXSYSTM:00/device:00/ACPI0000:00/power1_average_min", val: "345000000"},
70
{name: "/sys/devices/LNXSYSTM:00/device:00/ACPI0000:00/power1_input", val: "345000000"},
71
{name: "/sys/devices/LNXSYSTM:00/device:00/ACPI0000:00/power1_input_highest", val: "345000000"},