diskstats: change default configuration
Also enable performance charts for mounted virtual disks by default.
Simon Nagl committed
May 21, 2016 at 11:49 UTC
48938e3568383f44bd3d78f64a4adb26df3d95d1
2 files changed
+5
-2
src/proc_diskstats.c
+4
-1
@@ -136,7 +136,7 @@ int do_proc_diskstats(int update_every, unsigned long long dt) {
136
static procfile *ff = NULL;
137
static char path_to_get_hw_sector_size[FILENAME_MAX + 1] = "";
138
static int enable_autodetection;
139
- static int enable_physical_disks, enable_virtual_disks, enable_partitions, enable_mountpoints, enable_space_metrics;
139
+ static int enable_physical_disks, enable_virtual_disks, enable_partitions, enable_mountpoints, enable_virtual_mountpoints, enable_space_metrics;
140
static int do_io, do_ops, do_mops, do_iotime, do_qops, do_util, do_backlog, do_space, do_inodes;
141
static struct statvfs buff_statvfs;
142
static struct stat buff_stat;
@@ -147,6 +147,7 @@ int do_proc_diskstats(int update_every, unsigned long long dt) {
147
enable_virtual_disks = config_get_boolean_ondemand("plugin:proc:/proc/diskstats", "performance metrics for virtual disks", CONFIG_ONDEMAND_NO);
148
enable_partitions = config_get_boolean_ondemand("plugin:proc:/proc/diskstats", "performance metrics for partitions", CONFIG_ONDEMAND_NO);
149
enable_mountpoints = config_get_boolean_ondemand("plugin:proc:/proc/diskstats", "performance metrics for mounted filesystems", CONFIG_ONDEMAND_NO);
150
+ enable_virtual_mountpoints = config_get_boolean_ondemand("plugin:proc:/proc/diskstats", "performance metrics for mounted virtual disks", CONFIG_ONDEMAND_ONDEMAND);
151
enable_space_metrics = config_get_boolean_ondemand("plugin:proc:/proc/diskstats", "space metrics for mounted filesystems", CONFIG_ONDEMAND_ONDEMAND);
152
153
do_io = config_get_boolean_ondemand("plugin:proc:/proc/diskstats", "bandwidth for all disks", CONFIG_ONDEMAND_ONDEMAND);
@@ -267,6 +268,8 @@ int do_proc_diskstats(int update_every, unsigned long long dt) {
268
def_performance = enable_virtual_disks;
269
} else if(enable_partitions && (d->type == DISK_TYPE_PARTITION)) {
270
def_performance = enable_partitions;
271
+ } else if(enable_virtual_mountpoints && (d->type == DISK_TYPE_CONTAINER) && (d->mount_point != NULL)) {
272
+ def_performance = enable_virtual_mountpoints;
273
} else if(enable_mountpoints && (d->mount_point != NULL)) {
274
def_performance = enable_mountpoints;
275
}
web/index.html
+1
-1
@@ -1192,7 +1192,7 @@ var menuData = {
1192
1193
'disk': {
1194
title: 'Disks',
1195
- info: 'Charts with performance information for all the system disks. Special care has been given to present disk performance metrics in a way compatible with <code>iostat -x</code>. netdata by default prevents rendering performance charts for individual partitions. Partitions can still be enabled by altering the relative settings in the netdata configuration file.'
1195
+ info: 'Charts with performance information for all the system disks. Special care has been given to present disk performance metrics in a way compatible with <code>iostat -x</code>. netdata by default prevents rendering performance charts for individual partitions and unmounted virtual disks. Disabled charts can still be enabled by altering the relative settings in the netdata configuration file.'
1196
},
1197
1198
'sensors': {