@cryptotaxi247 / netdata-1 / commits / 4a507c44f

Fix coverity issues (#15005)

Fix coverity issues 384022, 384021, 383825

Stelios Fragkakis committed May 3, 2023 at 18:08 UTC 4a507c44fafec690ee58adf80ec5abd480ef6afb

3 files changed +3 -3

ml/ml.cc

@@ -1542,6 +1542,7 @@ void ml_init()

1542 if (rc != SQLITE_OK) {

1543 error_report("Failed to create models table (%s, %s)", sqlite3_errstr(rc), err ? err : "");

1544 sqlite3_close(db);

1545 + sqlite3_free(err);

1546 db = NULL;

1547 }

1548 }

registry/registry.c

+2 -2

@@ -95,7 +95,7 @@ static int registry_json_person_url_callback(void *entry, void *data) {

95 buffer_json_add_array_item_array(w->response.data);

96 buffer_json_add_array_item_string(w->response.data, pu->machine->guid);

97 buffer_json_add_array_item_string(w->response.data, pu->url->url);

98 - buffer_json_add_array_item_uint64(w->response.data, pu->last_t * 1000);

98 + buffer_json_add_array_item_uint64(w->response.data, pu->last_t * (uint64_t) 1000);

99 buffer_json_add_array_item_uint64(w->response.data, pu->usages);

100 buffer_json_add_array_item_string(w->response.data, pu->machine_name);

101 buffer_json_array_close(w->response.data);

@@ -115,7 +115,7 @@ static int registry_json_machine_url_callback(const DICTIONARY_ITEM *item __mayb

115 buffer_json_add_array_item_array(w->response.data);

116 buffer_json_add_array_item_string(w->response.data, m->guid);

117 buffer_json_add_array_item_string(w->response.data, mu->url->url);

118 - buffer_json_add_array_item_uint64(w->response.data, mu->last_t * 1000);

118 + buffer_json_add_array_item_uint64(w->response.data, mu->last_t * (uint64_t) 1000);

119 buffer_json_add_array_item_uint64(w->response.data, mu->usages);

120 buffer_json_array_close(w->response.data);

121

web/server/web_client.c

-1

@@ -2027,7 +2027,6 @@ int web_client_socket_is_now_used_for_streaming(struct web_client *w) {

2027

2028 void web_client_decode_path_and_query_string(struct web_client *w, const char *path_and_query_string) {

2029 char buffer[NETDATA_WEB_REQUEST_URL_SIZE + 2];

2030 - buffer[0] = '?';

2030 buffer[0] = '\0';

2031

2032 buffer_flush(w->url_path_decoded);