Fix coverity issues (#15169)
* online is true at this point * ignore return value * Check sender existence
Stelios Fragkakis committed
Jun 9, 2023 at 15:15 UTC
4d0f2b5ef322e3da3a0182acb47780f002fbd4cc
2 files changed
+3
-4
streaming/receiver.c
+1
-1
@@ -600,7 +600,7 @@ bool stop_streaming_receiver(RRDHOST *host, const char *reason) {
600
}
601
602
static void rrdpush_send_error_on_taken_over_connection(struct receiver_state *rpt, const char *msg) {
603
- send_timeout(
603
+ (void) send_timeout(
604
#ifdef ENABLE_HTTPS
605
&rpt->ssl,
606
#endif
streaming/sender.c
+2
-3
@@ -1101,7 +1101,7 @@ void rrdpush_signal_sender_to_wake_up(struct sender_state *s) {
1101
static NETDATA_DOUBLE rrdhost_sender_replication_completion(RRDHOST *host, time_t now, size_t *instances) {
1102
size_t charts = rrdhost_sender_replicating_charts(host);
1103
NETDATA_DOUBLE completion;
1104
- if(!charts || !host->sender->replication.oldest_request_after_t)
1104
+ if(!charts || !host->sender || !host->sender->replication.oldest_request_after_t)
1105
completion = 100.0;
1106
else if(!host->sender->replication.latest_completed_before_t || host->sender->replication.latest_completed_before_t < host->sender->replication.oldest_request_after_t)
1107
completion = 0.0;
@@ -1159,8 +1159,7 @@ void rrdhost_sender_to_json(BUFFER *wb, RRDHOST *host, const char *key, time_t n
1159
snprintfz(buf, 1024, "[%s]:%d%s", peers.peer.ip, peers.peer.port, ssl ? ":SSL" : "");
1160
buffer_json_member_add_string(wb, "remote", buf);
1161
1162
- stream_capabilities_to_json_array(wb, online ? host->sender->capabilities : 0,
1163
- "capabilities");
1162
+ stream_capabilities_to_json_array(wb, host->sender->capabilities, "capabilities");
1163
1164
buffer_json_member_add_object(wb, "traffic");
1165
{