Fix handling of workflow artifacts. (#18726)
* Don't use symlinks when preparing static build artifacts. * Roll back to v4.4.0 for actions/upload-artifact action. There appears to be a bug in the latest release that is causing some files to not be found when creating artifacts. * Bump actions/upload-artifact to v4.4.2 which fixes the bugs.
Austin S. Hemmelgarn committed
Oct 8, 2024 at 16:37 UTC
5225520373514cf15352f6f538c659af24b4def1
4 files changed
+13
-13
.github/workflows/build.yml
+5
-5
@@ -151,7 +151,7 @@ jobs:
151
- name: Store
152
id: store
153
if: needs.file-check.outputs.run == 'true'
154
- uses: actions/upload-artifact@v4
154
+ uses: actions/upload-artifact@v4.4.2
155
with:
156
name: dist-tarball
157
path: artifacts/*.tar.gz
@@ -245,7 +245,7 @@ jobs:
245
- name: Store
246
id: store
247
if: needs.file-check.outputs.run == 'true'
248
- uses: actions/upload-artifact@v4
248
+ uses: actions/upload-artifact@v4.4.2
249
with:
250
name: dist-static-${{ matrix.arch }}
251
path: artifacts/*.gz.run
@@ -349,7 +349,7 @@ jobs:
349
timestamp-digest: SHA256
350
- name: Upload Installer
351
id: upload
352
- uses: actions/upload-artifact@v4
352
+ uses: actions/upload-artifact@v4.4.2
353
with:
354
name: windows-x86_64-installer
355
path: packaging\windows\netdata*.exe
@@ -440,7 +440,7 @@ jobs:
440
- name: Store Artifacts
441
id: store
442
if: needs.file-check.outputs.run == 'true'
443
- uses: actions/upload-artifact@v4
443
+ uses: actions/upload-artifact@v4.4.2
444
with:
445
name: final-artifacts
446
path: artifacts/*
@@ -926,7 +926,7 @@ jobs:
926
tags: test:${{ matrix.artifact_key }}
927
- name: Upload image artifact
928
id: upload
929
- uses: actions/upload-artifact@v4
929
+ uses: actions/upload-artifact@v4.4.2
930
with:
931
name: ${{ matrix.artifact_key }}-test-env
932
path: /tmp/image.tar
.github/workflows/docker.yml
+4
-4
@@ -178,7 +178,7 @@ jobs:
178
- name: Upload Cache
179
id: upload-cache
180
if: github.repository == 'netdata/netdata' && needs.file-check.outputs.run == 'true' && github.event_name == 'workflow_dispatch'
181
- uses: actions/upload-artifact@v4
181
+ uses: actions/upload-artifact@v4.4.2
182
with:
183
name: cache-${{ steps.artifact-name.outputs.platform }}
184
path: /tmp/build-cache/*
@@ -296,7 +296,7 @@ jobs:
296
- name: Upload digest
297
id: upload-digest
298
if: github.repository == 'netdata/netdata'
299
- uses: actions/upload-artifact@v4
299
+ uses: actions/upload-artifact@v4.4.2
300
with:
301
name: docker-digests-${{ steps.artifact-name.outputs.platform }}
302
path: /tmp/digests/*
@@ -451,7 +451,7 @@ jobs:
451
- name: Upload digest
452
id: upload-digest
453
if: github.repository == 'netdata/netdata'
454
- uses: actions/upload-artifact@v4
454
+ uses: actions/upload-artifact@v4.4.2
455
with:
456
name: quay-digests-${{ steps.artifact-name.outputs.platform }}
457
path: /tmp/digests/*
@@ -607,7 +607,7 @@ jobs:
607
- name: Upload digest
608
id: upload-digest
609
if: github.repository == 'netdata/netdata'
610
- uses: actions/upload-artifact@v4
610
+ uses: actions/upload-artifact@v4.4.2
611
with:
612
name: ghcr-digests-${{ steps.artifact-name.outputs.platform }}
613
path: /tmp/digests/*
.github/workflows/packaging.yml
+1
-1
@@ -265,7 +265,7 @@ jobs:
265
id: artifacts
266
if: needs.file-check.outputs.run == 'true'
267
continue-on-error: true
268
- uses: actions/upload-artifact@v4
268
+ uses: actions/upload-artifact@v4.4.2
269
with:
270
name: ${{ matrix.distro }}-${{ matrix.version }}-${{ matrix.arch }}-packages
271
path: ${{ github.workspace }}/artifacts/*
packaging/makeself/jobs/99-makeself.install.sh
+3
-3
@@ -104,13 +104,13 @@ run mkdir -p artifacts
104
run mv "${NETDATA_INSTALL_PATH}.gz.run" "artifacts/${FILE}"
105
106
[ -f "netdata-${BUILDARCH}-latest.gz.run" ] && rm "netdata-${BUILDARCH}-latest.gz.run"
107
-run ln -s "artifacts/${FILE}" "netdata-${BUILDARCH}-latest.gz.run"
107
+run cp "artifacts/${FILE}" "netdata-${BUILDARCH}-latest.gz.run"
108
109
if [ "${BUILDARCH}" = "x86_64" ]; then
110
[ -f "netdata-latest.gz.run" ] && rm "netdata-latest.gz.run"
111
- run ln -s "artifacts/${FILE}" "netdata-latest.gz.run"
111
+ run cp "artifacts/${FILE}" "netdata-latest.gz.run"
112
[ -f "artifacts/netdata-${VERSION}.gz.run" ] && rm "netdata-${VERSION}.gz.run"
113
- run ln -s "./${FILE}" "artifacts/netdata-${VERSION}.gz.run"
113
+ run cp "artifacts/${FILE}" "artifacts/netdata-${VERSION}.gz.run"
114
fi
115
116
# shellcheck disable=SC2015