minor - silence misleading error (#14013)
silence missleading error
Timotej S committed
Nov 18, 2022 at 19:24 UTC
53e64f0e976adf865091659b671369e2e4eabc3f
3 files changed
+6
-5
aclk/aclk_query.c
+4
-3
@@ -256,7 +256,7 @@ static int send_bin_msg(struct aclk_query_thread *query_thr, aclk_query_t query)
256
return 0;
257
}
258
259
-const char *aclk_query_get_name(aclk_query_type_t qt)
259
+const char *aclk_query_get_name(aclk_query_type_t qt, int unknown_ok)
260
{
261
switch (qt) {
262
case HTTP_API_V2: return "http_api_request_v2";
@@ -273,7 +273,8 @@ const char *aclk_query_get_name(aclk_query_type_t qt)
273
case UPDATE_NODE_COLLECTORS: return "update_node_collectors";
274
case PROTO_BIN_MESSAGE: return "generic_binary_proto_message";
275
default:
276
- error_report("Unknown query type used %d", (int) qt);
276
+ if (!unknown_ok)
277
+ error_report("Unknown query type used %d", (int) qt);
278
return "unknown";
279
}
280
}
@@ -322,7 +323,7 @@ int aclk_query_process_msgs(struct aclk_query_thread *query_thr)
323
static void worker_aclk_register(void) {
324
worker_register("ACLKQUERY");
325
for (int i = 1; i < ACLK_QUERY_TYPE_COUNT; i++) {
325
- worker_register_job_name(i, aclk_query_get_name(i));
326
+ worker_register_job_name(i, aclk_query_get_name(i, 0));
327
}
328
}
329
aclk/aclk_query.h
+1
-1
@@ -31,6 +31,6 @@ struct aclk_query_threads {
31
void aclk_query_threads_start(struct aclk_query_threads *query_threads, mqtt_wss_client client);
32
void aclk_query_threads_cleanup(struct aclk_query_threads *query_threads);
33
34
-const char *aclk_query_get_name(aclk_query_type_t qt);
34
+const char *aclk_query_get_name(aclk_query_type_t qt, int unknown_ok);
35
36
#endif //NETDATA_AGENT_CLOUD_LINK_H
aclk/aclk_stats.c
+1
-1
@@ -129,7 +129,7 @@ static void aclk_stats_cloud_req_type(struct aclk_metrics_per_sample *per_sample
129
"netdata", "stats", 200006, localhost->rrd_update_every, RRDSET_TYPE_STACKED);
130
131
for (int i = 0; i < ACLK_QUERY_TYPE_COUNT; i++)
132
- dims[i] = rrddim_add(st, aclk_query_get_name(i), NULL, 1, localhost->rrd_update_every, RRD_ALGORITHM_ABSOLUTE);
132
+ dims[i] = rrddim_add(st, aclk_query_get_name(i, 1), NULL, 1, localhost->rrd_update_every, RRD_ALGORITHM_ABSOLUTE);
133
134
} else
135
rrdset_next(st);