Fix an overflow when unsigned integer subtracted (#11638)
Vladimir Kobal committed
Oct 8, 2021 at 16:07 UTC
5445c460b55c051a16799bd23ba60d92d4d15faf
1 file changed
+2
-2
collectors/cgroups.plugin/sys_fs_cgroup.c
+2
-2
@@ -2915,7 +2915,7 @@ void update_systemd_services_charts(
2915
rrddim_set_by_pointer(
2916
st_swap_usage,
2917
cg->rd_swap_usage,
2918
- (cg->memory.msw_usage_in_bytes - (cg->memory.usage_in_bytes + cg->memory.total_inactive_file)) > 0 ?
2918
+ cg->memory.msw_usage_in_bytes > (cg->memory.usage_in_bytes + cg->memory.total_inactive_file) ?
2919
cg->memory.msw_usage_in_bytes - (cg->memory.usage_in_bytes + cg->memory.total_inactive_file) : 0);
2920
} else {
2921
rrddim_set_by_pointer(st_swap_usage, cg->rd_swap_usage, cg->memory.msw_usage_in_bytes);
@@ -3609,7 +3609,7 @@ void update_cgroup_charts(int update_every) {
3609
rrddim_set(
3610
cg->st_mem_usage,
3611
"swap",
3612
- (cg->memory.msw_usage_in_bytes - (cg->memory.usage_in_bytes + cg->memory.total_inactive_file)) > 0 ?
3612
+ cg->memory.msw_usage_in_bytes > (cg->memory.usage_in_bytes + cg->memory.total_inactive_file) ?
3613
cg->memory.msw_usage_in_bytes - (cg->memory.usage_in_bytes + cg->memory.total_inactive_file) : 0);
3614
} else {
3615
rrddim_set(cg->st_mem_usage, "swap", cg->memory.msw_usage_in_bytes);