more LGTM minor fixes (#4211)
* more LGTM minor fixes * fixed duplicate id
Costa Tsaousis committed
Sep 17, 2018 at 04:55 UTC
57d0392f1da6791f38641366255b5c98e1094600
5 files changed
+9
-9
src/apps_plugin.c
+1
-1
@@ -1360,7 +1360,7 @@ int file_descriptor_compare(void* a, void* b) {
1360
return strcmp(((struct file_descriptor *)a)->name, ((struct file_descriptor *)b)->name);
1361
}
1362
1363
-int file_descriptor_iterator(avl *a) { if(a) {}; return 0; }
1363
+// int file_descriptor_iterator(avl *a) { if(a) {}; return 0; }
1364
1365
avl_tree all_files_index = {
1366
NULL,
src/freeipmi_plugin.c
+4
-4
@@ -47,8 +47,8 @@ char *driver_device = NULL; /* not used if probing */
47
int protocol_version = -1; //IPMI_MONITORING_PROTOCOL_VERSION_1_5; /* or -1 for default */
48
char *username = "foousername";
49
char *password = "foopassword";
50
-unsigned char *k_g = NULL;
51
-unsigned int k_g_len = 0;
50
+unsigned char *ipmi_k_g = NULL;
51
+unsigned int ipmi_k_g_len = 0;
52
int privilege_level = -1; // IPMI_MONITORING_PRIVILEGE_LEVEL_USER; /* or -1 for default */
53
int authentication_type = -1; // IPMI_MONITORING_AUTHENTICATION_TYPE_MD5; /* or -1 for default */
54
int cipher_suite_id = 0; /* or -1 for default */
@@ -124,8 +124,8 @@ _init_ipmi_config (struct ipmi_monitoring_ipmi_config *ipmi_config)
124
ipmi_config->protocol_version = protocol_version;
125
ipmi_config->username = username;
126
ipmi_config->password = password;
127
- ipmi_config->k_g = k_g;
128
- ipmi_config->k_g_len = k_g_len;
127
+ ipmi_config->k_g = ipmi_k_g;
128
+ ipmi_config->k_g_len = ipmi_k_g_len;
129
ipmi_config->privilege_level = privilege_level;
130
ipmi_config->authentication_type = authentication_type;
131
ipmi_config->cipher_suite_id = cipher_suite_id;
src/sys_fs_cgroup.c
+1
-1
@@ -72,7 +72,7 @@ void read_cgroup_plugin_configuration() {
72
if(cgroup_update_every < localhost->rrd_update_every)
73
cgroup_update_every = localhost->rrd_update_every;
74
75
- cgroup_check_for_new_every = (int)config_get_number("plugin:cgroups", "check for new cgroups every", cgroup_check_for_new_every * cgroup_update_every);
75
+ cgroup_check_for_new_every = (int)config_get_number("plugin:cgroups", "check for new cgroups every", (long long)cgroup_check_for_new_every * (long long)cgroup_update_every);
76
if(cgroup_check_for_new_every < cgroup_update_every)
77
cgroup_check_for_new_every = cgroup_update_every;
78
src/web_client.h
+1
-1
@@ -100,7 +100,7 @@ struct response {
100
Bytef zbuffer[NETDATA_WEB_RESPONSE_ZLIB_CHUNK_SIZE]; // temporary buffer for storing compressed output
101
size_t zsent; // the compressed bytes we have sent to the client
102
size_t zhave; // the compressed bytes that we have received from zlib
103
- int zinitialized:1;
103
+ unsigned int zinitialized:1;
104
#endif /* NETDATA_WITH_ZLIB */
105
106
};
web/dashboard.html
+2
-2
@@ -683,10 +683,10 @@ So, to avoid flashing the charts, we destroy and re-create the charts on each up
683
data-points="60"
684
data-debug="false"
685
data-decimal-digits="0"
686
- data-dt-element-name="time902"
686
+ data-dt-element-name="time903"
687
></div>
688
<br/>
689
- <small>rendered in <span id="time902">X</span> ms</small>
689
+ <small>rendered in <span id="time903">X</span> ms</small>
690
</div>
691
</div> <!-- 1st container -->
692
</body>