@cryptotaxi247 / netdata-1 / commits / 5c64d5f11

Code cleanup (#20673)

* remove analystics send commented out code * Fix compilation warning * Add cmd pool to standard unittest Fix coverity warning on cmd pool unit test * Increase metadata timeout to 15 seconds on exit * Remove commented out code

Stelios Fragkakis committed Jul 14, 2025 at 18:02 UTC 5c64d5f11b6ab69bf855a30146da412b5141e686

6 files changed +4 -14

src/daemon/analytics.h

-7

@@ -91,13 +91,6 @@ void get_system_timezone(void);

91 void analytics_reset(void);

92 void analytics_init(void);

94 -typedef struct {

95 - const char *action;

96 - const char *result;

97 - const char *data;

98 -} analytics_statistic_t;

99 -

100 -void analytics_statistic_send(const analytics_statistic_t *statistic);

94 bool analytics_check_enabled(void);

96 extern struct analytics_data analytics_data;

src/daemon/daemon-shutdown.c

-4

@@ -202,10 +202,6 @@ static void netdata_cleanup_and_exit(EXIT_REASON reason, bool abnormal, bool exi

202 }

203 #endif

204

205 - // notify we are exiting

206 - //analytics_statistic_t statistic = (analytics_statistic_t) {"EXIT", abnormal?"ERROR":"OK","-"};

207 - //analytics_statistic_send(&statistic);

208 -

205 webrtc_close_all_connections();

206 watcher_step_complete(WATCHER_STEP_ID_CLOSE_WEBRTC_CONNECTIONS);

207

src/daemon/libuv_workers.c

+1 -1

@@ -228,7 +228,7 @@ void push_thread(void *arg) {

228 ThreadArgs *args = (ThreadArgs *)arg;

229 CmdPool *pool = args->pool;

230 for (int i = 0; i < args->total; ++i) {

231 - cmd_data_t cmd;

231 + cmd_data_t cmd = { 0 };

232 snprintf(cmd.data, sizeof(cmd.data), "cmd-%d", i);

233 push_cmd(pool, &cmd, true);

234 }

src/daemon/main.c

@@ -409,6 +409,7 @@ int netdata_main(int argc, char **argv) {

409 if (unittest_waiting_queue()) return 1;

410 if (uuidmap_unittest()) return 1;

411 if (stacktrace_unittest()) return 1;

412 + if (test_cmd_pool_fifo()) return 1;

413 #ifdef OS_WINDOWS

414 if (perflibnamestest_main()) return 1;

415 #endif

src/database/sqlite/sqlite_metadata.c

+1 -1

@@ -2453,7 +2453,7 @@ static void start_metadata_hosts(uv_work_t *req)

2453

2454 #define EVENT_LOOP_NAME "METASYNC"

2455

2456 -#define MAX_SHUTDOWN_TIMEOUT_SECONDS (10)

2456 +#define MAX_SHUTDOWN_TIMEOUT_SECONDS (15)

2457 #define SHUTDOWN_SLEEP_INTERVAL_MS (100)

2458 #define CMD_POOL_SIZE (32768)

2459

src/web/websocket/websocket-thread.c

+1 -1

@@ -186,7 +186,7 @@ static ssize_t read_pipe_block(int fd, void *buffer, size_t size) {

186 char *buf = buffer;

187 ssize_t total_read = 0;

188

189 - while (total_read < size) {

189 + while (total_read < (ssize_t) size) {

190 ssize_t bytes = read(fd, buf + total_read, size - total_read);

191

192 if (bytes < 0) {