Require cloud build to succeed in make dist checks. (#9218)
* Require cloud build to succeed in make dist checks. * perform dist check the same way we normally do builds. The default behavior in `kickstart.sh` is to run `install-required-packages.sh` with just the `netdata` package set, and we don't even document how to make it run with `netdata-all`, so a vast majority of users will only be running using the `netdata` package set. * More accurately recreate the environment a user would be building in. We should be testing our distfiles against our current version of `install-required-packages.sh`, not some pre-generated test image that we have to manage ina separaterepo. Also, disable telemetry for the test build so we don't accidentally pollute the stats.
Austin S. Hemmelgarn committed
Aug 3, 2020 at 02:17 UTC
5f160bea3058cb5f806b1a402ef999b99880300c
2 files changed
+4
-3
.github/scripts/run_install_with_dist_file.sh
+3
-2
@@ -19,6 +19,7 @@ shift
19
printf >&2 "Opening dist archive %s ... " "${distfile}"
20
tar -xovf "${distfile}"
21
distdir="$(echo "${distfile}" | cut -d. -f1,2,3)"
22
+cp -a packaging/installer/install-required-packages.sh "${distdir}/install-required-packages.sh"
23
if [ ! -d "${distdir}" ]; then
24
printf >&2 "ERROR: %s is not a directory" "${distdir}"
25
exit 2
@@ -30,8 +31,8 @@ pushd "${distdir}" || exit 1
31
docker run \
32
-v "${PWD}:/netdata" \
33
-w /netdata \
33
- "netdata/os-test:centos7" \
34
- /bin/bash -c "./netdata-installer.sh --dont-wait --install /tmp && echo \"Validating netdata instance is running\" && wget -O - 'http://127.0.0.1:19999/api/v1/info' | grep version"
34
+ "ubuntu:latest" \
35
+ /bin/bash -c "./install-required-packages.sh --dont-wait --non-interactive netdata && apt install wget && ./netdata-installer.sh --dont-wait --require-cloud --disable-telemetry --install /tmp && echo \"Validating netdata instance is running\" && wget -O - 'http://127.0.0.1:19999/api/v1/info' | grep version"
36
popd || exit 1
37
38
echo "All Done!"
.github/workflows/checks.yml
+1
-1
@@ -61,7 +61,7 @@ jobs:
61
uses: actions/checkout@v2
62
- name: Prepare environment
63
run: |
64
- ./packaging/installer/install-required-packages.sh --dont-wait --non-interactive netdata-all
64
+ ./packaging/installer/install-required-packages.sh --dont-wait --non-interactive netdata
65
sudo apt-get install -y libjson-c-dev libipmimonitoring-dev libcups2-dev libsnappy-dev \
66
libprotobuf-dev libprotoc-dev libssl-dev protobuf-compiler \
67
libnetfilter-acct-dev