Default to release with debug symbols for Windows builds. (#18230)
Austin S. Hemmelgarn committed
Jul 29, 2024 at 18:22 UTC
5fb59bfd44d245a3a98b697d596f6a598480fc9f
1 file changed
+12
-4
packaging/windows/compile-on-windows.sh
+12
-4
@@ -1,7 +1,7 @@
1
#!/bin/bash
2
3
repo_root="$(dirname "$(dirname "$(cd "$(dirname "${BASH_SOURCE[0]}")" > /dev/null && pwd -P)")")"
4
-BUILD_TYPE="Debug"
4
+CMAKE_BUILD_TYPE="${CMAKE_BUILD_TYPE:-RelWithDebInfo}"
5
6
if [ -n "${BUILD_DIR}" ]; then
7
build="${BUILD_DIR}"
@@ -31,13 +31,21 @@ if command -v ninja >/dev/null 2>&1; then
31
build_args="-k 1"
32
fi
33
34
+COMMON_CFLAGS="-Wa,-mbig-obj -pipe -D_FILE_OFFSET_BITS=64 -D__USE_MINGW_ANSI_STDIO=1"
35
+
36
+if [ "${CMAKE_BUILD_TYPE}" = "Debug" ]; then
37
+ BUILD_CFLAGS="-fstack-protector-all -O0 -ggdb -Wall -Wextra -Wno-char-subscripts -DNETDATA_INTERNAL_CHECKS=1 ${COMMON_CFLAGS} ${CFLAGS:-}"
38
+else
39
+ BUILD_CFLAGS="-O2 ${COMMON_CFLAGS} ${CFLAGS:-}"
40
+fi
41
+
42
${GITHUB_ACTIONS+echo "::group::Configuring"}
43
# shellcheck disable=SC2086
36
-/usr/bin/cmake -S "${repo_root}" -B "${build}" \
44
+CFLAGS="${BUILD_CFLAGS}" /usr/bin/cmake \
45
+ -S "${repo_root}" \
46
+ -B "${build}" \
47
-G "${generator}" \
48
-DCMAKE_INSTALL_PREFIX="/opt/netdata" \
39
- -DCMAKE_BUILD_TYPE="${BUILD_TYPE}" \
40
- -DCMAKE_C_FLAGS="-fstack-protector-all -O0 -ggdb -Wall -Wextra -Wno-char-subscripts -Wa,-mbig-obj -pipe -DNETDATA_INTERNAL_CHECKS=1 -D_FILE_OFFSET_BITS=64 -D__USE_MINGW_ANSI_STDIO=1" \
49
-DBUILD_FOR_PACKAGING=On \
50
-DNETDATA_USER="${USER}" \
51
-DENABLE_ACLK=On \