Correctly handle basic permissions for most scripts on install. (#16629)
This fixes most of the scripts installed by cmake so that they correctly have execute permissions. We need to do more work than just this (such as properly handling the SUID bit), but this is a solid starting point.
Austin S. Hemmelgarn committed
Dec 19, 2023 at 07:36 UTC
636396a52b59e35893cc9700cce8619b6959f1c2
1 file changed
+6
-6
CMakeLists.txt
+6
-6
@@ -1911,10 +1911,10 @@ install(PROGRAMS system/edit-config DESTINATION etc/netdata)
1911
# TODO: check the following files for correct substitutions
1912
#
1913
configure_file(daemon/anonymous-statistics.sh.in daemon/anonymous-statistics.sh @ONLY)
1914
-install(FILES ${CMAKE_BINARY_DIR}/daemon/anonymous-statistics.sh DESTINATION usr/libexec/netdata/plugins.d)
1914
+install(PROGRAMS ${CMAKE_BINARY_DIR}/daemon/anonymous-statistics.sh DESTINATION usr/libexec/netdata/plugins.d)
1915
1916
configure_file(daemon/get-kubernetes-labels.sh.in daemon/get-kubernetes-labels.sh @ONLY)
1917
-install(FILES ${CMAKE_BINARY_DIR}/daemon/get-kubernetes-labels.sh DESTINATION usr/libexec/netdata/plugins.d)
1917
+install(PROGRAMS ${CMAKE_BINARY_DIR}/daemon/get-kubernetes-labels.sh DESTINATION usr/libexec/netdata/plugins.d)
1918
1919
install(PROGRAMS daemon/system-info.sh
1920
DESTINATION usr/libexec/netdata/plugins.d)
@@ -1960,7 +1960,7 @@ install(FILES ${CMAKE_BINARY_DIR}/tests/health_mgmtapi/health-cmdapi-test.sh
1960
#
1961
1962
configure_file(collectors/charts.d.plugin/charts.d.plugin.in collectors/charts.d.plugin/charts.d.plugin @ONLY)
1963
-install(FILES ${CMAKE_BINARY_DIR}/collectors/charts.d.plugin/charts.d.plugin
1963
+install(PROGRAMS ${CMAKE_BINARY_DIR}/collectors/charts.d.plugin/charts.d.plugin
1964
DESTINATION usr/libexec/netdata/plugins.d)
1965
1966
install(FILES collectors/charts.d.plugin/charts.d.dryrun-helper.sh
@@ -1975,7 +1975,7 @@ install(FILES collectors/charts.d.plugin/charts.d.conf
1975
#
1976
1977
configure_file(collectors/tc.plugin/tc-qos-helper.sh.in collectors/tc.plugin/tc-qos-helper.sh @ONLY)
1978
-install(FILES ${CMAKE_BINARY_DIR}/collectors/tc.plugin/tc-qos-helper.sh
1978
+install(PROGRAMS ${CMAKE_BINARY_DIR}/collectors/tc.plugin/tc-qos-helper.sh
1979
DESTINATION usr/libexec/netdata/plugins.d)
1980
1981
# scripts
@@ -2031,7 +2031,7 @@ endif()
2031
#
2032
2033
configure_file(collectors/python.d.plugin/python.d.plugin.in collectors/python.d.plugin/python.d.plugin @ONLY)
2034
-install(FILES ${CMAKE_BINARY_DIR}/collectors/python.d.plugin/python.d.plugin
2034
+install(PROGRAMS ${CMAKE_BINARY_DIR}/collectors/python.d.plugin/python.d.plugin
2035
DESTINATION usr/libexec/netdata/plugins.d)
2036
2037
install(DIRECTORY collectors/python.d.plugin/python_modules
@@ -2142,7 +2142,7 @@ install(FILES collectors/python.d.plugin/adaptec_raid/adaptec_raid.chart.py
2142
2143
# FIXME: don't install this unconditionally
2144
configure_file(collectors/ioping.plugin/ioping.plugin.in collectors/ioping.plugin/ioping.plugin @ONLY)
2145
-install(FILES ${CMAKE_BINARY_DIR}/collectors/ioping.plugin/ioping.plugin DESTINATION usr/libexec/netdata/plugins.d)
2145
+install(PROGRAMS ${CMAKE_BINARY_DIR}/collectors/ioping.plugin/ioping.plugin DESTINATION usr/libexec/netdata/plugins.d)
2146
2147
#
2148
# logs management