Add 0 to http response time on errors, otherwise the chart will get suppressed on error recovery.
Chris committed
Feb 25, 2018 at 14:40 UTC
6914090ff8ca657ed464fe9f289c779d028a8d70
2 files changed
+3
-1
python.d/httpcheck.chart.py
+2
-1
@@ -37,7 +37,7 @@ CHARTS = {
37
[HTTP_RESPONSE_TIME, 'response time', 'absolute', 100, 1000]
38
]},
39
'error': {
40
- 'options': [None, 'HTTP check error code', 'code', 'error', 'httpcheck.error', 'line'],
40
+ 'options': [None, 'HTTP check error code', 'yes/no', 'error', 'httpcheck.error', 'line'],
41
'lines': [
42
[HTTP_SUCCESS, 'success', 'absolute'],
43
[HTTP_UNEXPECTED_CONTENT, 'unexpected content', 'absolute'],
@@ -84,6 +84,7 @@ class Service(UrlService):
84
:return: dict
85
"""
86
data = dict()
87
+ data[HTTP_RESPONSE_TIME] = 0
88
data[HTTP_SUCCESS] = 0
89
data[HTTP_UNEXPECTED_CONTENT] = 0
90
data[HTTP_UNEXPECTED_STATUS] = 0
web/dashboard_info.js
+1
@@ -1138,6 +1138,7 @@ netdataDashboard.context = {
1138
1139
'httpcheck.responsetime': {
1140
info: 'The <code>response time</code> describes the time passed between request and response. ' +
1141
+ 'The minimum is <code>0.1 ms</code> except on errors, where it will be <code>0.0 ms</code> ' +
1142
'Currently, the accuracy of the response time is low and should be used as reference only.'
1143
},
1144