Fix Valgrind errors (#12619)
Vladimir Kobal committed
Apr 19, 2022 at 09:59 UTC
72a5ec6e37d22dd6c7cfe2562ef72bc86025b114
5 files changed
+8
-2
aclk/aclk_alarm_api.c
+2
@@ -23,6 +23,8 @@ void aclk_send_alarm_log_entry(struct alarm_log_entry *log_entry)
23
char *payload = generate_alarm_log_entry(&payload_size, log_entry);
24
25
aclk_send_bin_msg(payload, payload_size, ACLK_TOPICID_ALARM_LOG, "AlarmLogEntry");
26
+
27
+ freez(payload);
28
}
29
30
void aclk_send_provide_alarm_cfg(struct provide_alarm_configuration *cfg)
aclk/aclk_stats.c
+1
-1
@@ -364,7 +364,7 @@ void aclk_stats_upd_online(int online) {
364
}
365
366
#ifdef NETDATA_INTERNAL_CHECKS
367
-static usec_t pub_time[UINT16_MAX];
367
+static usec_t pub_time[UINT16_MAX + 1] = {0};
368
void aclk_stats_msg_published(uint16_t id)
369
{
370
ACLK_STATS_LOCK;
aclk/schema-wrappers/alarm_stream.cc
+3
-1
@@ -176,8 +176,10 @@ char *generate_alarm_log_entry(size_t *len, struct alarm_log_entry *data)
176
177
*len = PROTO_COMPAT_MSG_SIZE(le);
178
char *bin = (char*)mallocz(*len);
179
- if (!le.SerializeToArray(bin, *len))
179
+ if (!le.SerializeToArray(bin, *len)) {
180
+ freez(bin);
181
return NULL;
182
+ }
183
184
return bin;
185
}
database/engine/journalfile.c
+1
@@ -84,6 +84,7 @@ void * wal_get_transaction_buffer(struct rrdengine_worker_config* wc, unsigned s
84
if (unlikely(ret)) {
85
fatal("posix_memalign:%s", strerror(ret));
86
}
87
+ memset(ctx->commit_log.buf, 0, buf_size);
88
buf_pos = ctx->commit_log.buf_pos = 0;
89
ctx->commit_log.buf_size = buf_size;
90
}
database/engine/rrdengine.c
+1
@@ -735,6 +735,7 @@ static int do_flush_pages(struct rrdengine_worker_config* wc, int force, struct
735
fatal("posix_memalign:%s", strerror(ret));
736
/* freez(xt_io_descr);*/
737
}
738
+ memset(xt_io_descr->buf, 0, ALIGN_BYTES_CEILING(size_bytes));
739
(void) memcpy(xt_io_descr->descr_array, eligible_pages, sizeof(struct rrdeng_page_descr *) * count);
740
xt_io_descr->descr_count = count;
741