rename "Pid" to "PID" in functions (#14144)
* rename "Pid" to "PID" in functions I think it would be better for the case of "Pid" if we stuck to generally expected convention of "PID" * `PPid` to `PPID` * `Pid` to `PID` for pointer in PPID * ignore "Gid" and "Uid" from this PR
Andrew Maguire committed
Jan 11, 2023 at 22:42 UTC
8192354570c65ca027272d38289c2ecf78dd446f
1 file changed
+6
-6
collectors/apps.plugin/apps_plugin.c
+6
-6
@@ -4591,13 +4591,13 @@ static void apps_plugin_function_processes(const char *transaction, char *functi
4591
4592
// IMPORTANT!
4593
// THE ORDER SHOULD BE THE SAME WITH THE VALUES!
4594
- add_table_field(wb, "Pid", "Process ID", true, "integer", NULL, NAN, "ascending", true, true, true, NULL, "count_unique", false);
4594
+ add_table_field(wb, "PID", "Process ID", true, "integer", NULL, NAN, "ascending", true, true, true, NULL, "count_unique", false);
4595
add_table_field(wb, "Cmd", "Process Name", true, "string", NULL, NAN, "ascending", true, true, false, NULL, "count_unique", false);
4596
4597
#ifdef NETDATA_DEV_MODE
4598
add_table_field(wb, "CmdLine", "Command Line", false, "detail-string:Cmd", NULL, NAN, "ascending", true, false, false, NULL, "count_unique", false);
4599
#endif
4600
- add_table_field(wb, "PPid", "Parent Process ID", false, "integer", NULL, NAN, "ascending", true, false, false, "Pid", "count_unique", false);
4600
+ add_table_field(wb, "PPID", "Parent Process ID", false, "integer", NULL, NAN, "ascending", true, false, false, "PID", "count_unique", false);
4601
add_table_field(wb, "Category", "Category (apps_groups.conf)", true, "string", NULL, NAN, "ascending", true, true, false, NULL, "count_unique", false);
4602
add_table_field(wb, "User", "User Owner", true, "string", NULL, NAN, "ascending", true, false, false, NULL, "count_unique", false);
4603
add_table_field(wb, "Uid", "User ID", false, "integer", NULL, NAN, "ascending", true, false, false, NULL, "count_unique", false);
@@ -4748,19 +4748,19 @@ static void apps_plugin_function_processes(const char *transaction, char *functi
4748
"\n \"group_by\": {"
4749
"\n \"pid\": {"
4750
"\n \"name\":\"Process Tree by PID\","
4751
- "\n \"columns\":[ \"PPid\" ]"
4751
+ "\n \"columns\":[ \"PPID\" ]"
4752
"\n },"
4753
"\n \"category\": {"
4754
"\n \"name\":\"Process Tree by Category\","
4755
- "\n \"columns\":[ \"Category\", \"PPid\" ]"
4755
+ "\n \"columns\":[ \"Category\", \"PPID\" ]"
4756
"\n },"
4757
"\n \"user\": {"
4758
"\n \"name\":\"Process Tree by User\","
4759
- "\n \"columns\":[ \"User\", \"PPid\" ]"
4759
+ "\n \"columns\":[ \"User\", \"PPID\" ]"
4760
"\n },"
4761
"\n \"group\": {"
4762
"\n \"name\":\"Process Tree by Group\","
4763
- "\n \"columns\":[ \"Group\", \"PPid\" ]"
4763
+ "\n \"columns\":[ \"Group\", \"PPID\" ]"
4764
"\n }"
4765
"\n }"
4766
);