Print INTERNAL BUG messages only when NETDATA_INTERNAL_CHECKS is enabled (#13207)
put INTERNAL BUG messages inside NETDATA_INTERNAL_CHECKS
Emmanuel Vasilakis committed
Jun 23, 2022 at 17:01 UTC
88243b61f6087e84156adc8dbe08b534df17dc36
1 file changed
+8
web/api/queries/query.c
+8
@@ -509,12 +509,16 @@ static inline void rrd2rrdr_do_dimension(
509
}
510
511
if(unlikely(new_point_start_time == new_point_end_time)) {
512
+#ifdef NETDATA_INTERNAL_CHECKS
513
error("QUERY: INTERNAL BUG: next_metric(%s, %s) returned point start time %ld, end time %ld, that are both equal", rd->rrdset->name, rd->name, new_point_start_time, new_point_end_time);
514
+#endif
515
new_point_start_time = new_point_end_time - rd->update_every;
516
}
517
518
if(unlikely(new_point_start_time < last_point_start_time && new_point_end_time < last_point_end_time)) {
519
+#ifdef NETDATA_INTERNAL_CHECKS
520
error("QUERY: INTERNAL BUG: next_metric(%s, %s) returned point start time %ld, end time %ld, before the last point start time %ld, end time %ld", rd->rrdset->name, rd->name, new_point_start_time, new_point_end_time, last_point_start_time, last_point_end_time);
521
+#endif
522
new_point_value = last_point_value;
523
new_point_flags = last_point_flags;
524
new_point_start_time = last_point_start_time;
@@ -522,7 +526,9 @@ static inline void rrd2rrdr_do_dimension(
526
}
527
528
if(unlikely(new_point_end_time < last_point_end_time)) {
529
+#ifdef NETDATA_INTERNAL_CHECKS
530
error("QUERY: INTERNAL BUG: next_metric(%s, %s) returned point end time %ld, before the last point end time %ld", rd->rrdset->name, rd->name, new_point_end_time, last_point_end_time);
531
+#endif
532
new_point_value = last_point_value;
533
new_point_flags = last_point_flags;
534
new_point_start_time = last_point_start_time;
@@ -530,7 +536,9 @@ static inline void rrd2rrdr_do_dimension(
536
}
537
538
if(unlikely(new_point_end_time < now)) {
539
+#ifdef NETDATA_INTERNAL_CHECKS
540
error("QUERY: INTERNAL BUG: next_metric(%s, %s) returned point %ld to %ld, before now (now = %ld, after_wanted = %ld, before_wanted = %ld, dt = %ld)", rd->rrdset->name, rd->name, new_point_start_time, new_point_end_time, now, after_wanted, before_wanted, dt);
541
+#endif
542
new_point_end_time = now;
543
}
544
}