fix(go.d dyncfg): don't overwrite source (#19673)
Ilya Mashchenko committed
Feb 18, 2025 at 21:33 UTC
943bfe5286a4c1943594f767819eb6f6d4a0fe05
2 files changed
+2
-10
src/go/plugin/go.d/agent/jobmgr/dyncfg_collector.go
+1
-5
@@ -674,12 +674,8 @@ func (m *Manager) dyncfgConfigUpdate(fn functions.Function) {
674
}
675
676
func (m *Manager) dyncfgSetConfigMeta(cfg confgroup.Config, module, name string, fn functions.Function) {
677
- src := fmt.Sprintf("type=dyncfg,module=%s,job=%s", module, name)
678
- if v := getFnSourceValue(fn, "user"); v != "" {
679
- src += fmt.Sprintf(", user=%s", v)
680
- }
677
cfg.SetProvider("dyncfg")
682
- cfg.SetSource(src)
678
+ cfg.SetSource(fn.Source)
679
cfg.SetSourceType("dyncfg")
680
cfg.SetModule(module)
681
cfg.SetName(name)
src/go/plugin/go.d/agent/jobmgr/dyncfg_vnode.go
+1
-5
@@ -311,11 +311,7 @@ func (m *Manager) verifyVnodeUnique(newCfg *vnodes.VirtualNode) error {
311
312
func dyncfgUpdateVnodeConfig(cfg *vnodes.VirtualNode, name string, fn functions.Function) {
313
cfg.SourceType = confgroup.TypeDyncfg
314
- src := "type=dyncfg"
315
- if v := getFnSourceValue(fn, "user"); v != "" {
316
- src += fmt.Sprintf(", user=%s", v)
317
- }
318
- cfg.Source = src
314
+ cfg.Source = fn.Source
315
cfg.Name = name
316
if cfg.Hostname == "" {
317
cfg.Hostname = name